Bug 233804 - [GTK][a11y] Ensure atspi wrappers have root set at construction time
Summary: [GTK][a11y] Ensure atspi wrappers have root set at construction time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: ATSPI
  Show dependency treegraph
 
Reported: 2021-12-03 01:25 PST by Carlos Garcia Campos
Modified: 2021-12-28 23:37 PST (History)
11 users (show)

See Also:


Attachments
Patch (42.69 KB, patch)
2021-12-03 01:36 PST, Carlos Garcia Campos
jdiggs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-12-03 01:25:37 PST
It simplifies the code a lot and we ensure all wrappers always have a link to the root element.
Comment 1 Carlos Garcia Campos 2021-12-03 01:36:12 PST
Created attachment 445823 [details]
Patch
Comment 2 Joanmarie Diggs 2021-12-03 02:05:20 PST
Comment on attachment 445823 [details]
Patch

Thanks for doing this!
Comment 3 Adrian Perez 2021-12-03 02:10:21 PST
Comment on attachment 445823 [details]
Patch

Very nice to see quite a few parts of the ATSPI code simplified by
this patch. As usual, patches that remove code are among the nicest 😻️
Comment 4 Carlos Garcia Campos 2021-12-09 00:26:45 PST
Committed r286767 (245008@trunk): <https://commits.webkit.org/245008@trunk>