Bug 230647 - [GPU Process] `DisplayList::Recorder::getCTM` should include the device scale factor
Summary: [GPU Process] `DisplayList::Recorder::getCTM` should include the device scale...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-22 16:00 PDT by Devin Rousso
Modified: 2021-10-26 14:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.04 KB, patch)
2021-10-25 16:31 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-09-22 16:00:43 PDT 
.
Comment 1 Devin Rousso 2021-09-22 16:06:55 PDT 
(oops I think I changed the title of another bug I was gonna file and hit submit before I realized 🤣)

While working on <https://webkit.org/b/230648>, I noticed that `DisplayList::Recorder::getCTM` never seems to include the device scale, meaning that if I try to use `ImageBuffer::compatibleBufferSize` and then `GraphicsContext::drawConsumingImageBuffer` it'll result in a blurry image (since the device scale used for the `ImageBuffer` is just `1`).
Comment 2 Radar WebKit Bug Importer 2021-09-29 16:01:20 PDT 
<rdar://problem/83692923>
Comment 3 Tim Horton 2021-10-25 16:31:47 PDT 
Created attachment 442437 [details]
Patch
Comment 4 EWS 2021-10-26 14:50:35 PDT 
Committed r284902 (243579@main): <https://commits.webkit.org/243579@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442437 [details].