.
<rdar://problem/83187282>
Created attachment 439007 [details] Patch
Comment on attachment 439007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439007&action=review > Source/WebCore/ChangeLog:8 > + Is there a test that now passes? If not, (or perhaps even if) would probably be good to have one that draws the logo at various different sizes to make sure the scaling works.
Comment on attachment 439007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439007&action=review >> Source/WebCore/ChangeLog:8 >> + > > Is there a test that now passes? If not, (or perhaps even if) would probably be good to have one that draws the logo at various different sizes to make sure the scaling works. I don't believe there are any existing tests for this. Frankly I'm not entirely sure how to test this given that the actual content being drawn comes from a PDF in PassKit. I'm also being told that we don't like using `-expected.png` anymore nowadays 😅 Do you have any suggestions for testing this?
You can use transforms, clip-path etc to pick out solid-color parts of the drawn button and ref-test those.
Comment on attachment 439007 [details] Patch Devin is going to write a test (maybe just a cheap mismatch test) that would have failed before.
Created attachment 439816 [details] Patch
Comment on attachment 439816 [details] Patch Mismatch test really only works for a single case at a time (because any one passing will make the whole thing pass), would recommend splitting them.
Created attachment 440563 [details] Patch
Created attachment 440684 [details] Patch not sure what's going on with `background-repeat: repeat`, but this test also fails before my changes so I'm going to remove it for now a file a bug about that as a followup
Committed r283864 (242741@main): <https://commits.webkit.org/242741@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440684 [details].