Bug 217856 - webkitcorepy: Allow one package to require another package
Summary: webkitcorepy: Allow one package to require another package
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-16 16:36 PDT by Lauro Moura
Modified: 2020-10-18 20:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.82 KB, patch)
2020-10-16 16:49 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
Patch (7.55 KB, patch)
2020-10-16 21:27 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-10-16 16:36:20 PDT 
webkitcorepy: Allow one package to require another package
Comment 1 Lauro Moura 2020-10-16 16:49:12 PDT 
Created attachment 411630 [details]
Patch
Comment 2 Jonathan Bedard 2020-10-16 16:54:23 PDT 
Comment on attachment 411630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411630&action=review

> Tools/Scripts/webkitpy/__init__.py:54
> +AutoInstall.register(Package('pytest', Version(3, 6, 2), implicit_deps=['pytest_timeout']))

I'm not against this, although I recently added a feature (for things like zone.interface) that might be easier.  Does this work:

AutoInstall.register(Package('pytest', Version(3, 6, 2))
AutoInstall.register(Package('pytest_timeout', Version(1, 4, 2), pypi_name='pytest-timeout', aliases=['pytest']))
Comment 3 Lauro Moura 2020-10-16 21:27:20 PDT 
Created attachment 411654 [details]
Patch
Comment 4 EWS 2020-10-18 20:46:04 PDT 
Committed r268662: <https://trac.webkit.org/changeset/268662>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411654 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-18 20:47:20 PDT 
<rdar://problem/70426657>