Bug 215895 – [webkitpy] Use webkitcorepy's auto installer for pytest packages

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Part of removing webkitpy's autoinstaller in favor of webkitcorepy's.

[Radar WebKit Bug Importer]

<rdar://problem/67885471>

[Jonathan Bedard]

Created attachment 407420 [details]
Patch

[Aakash Jain]

Comment on attachment 407420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407420&action=review

> Tools/Scripts/webkitpy/__init__.py:32
> +AutoInstall.register(Package('configparser', Version(4, 0, 2)))

configparser is being added here, but not being removed? Is it a new requirement? (same with wcwidth, zipp, zope etc.)

If we are adding new packages, it's better to do add in a separate patch, and keep this patch just to transition from old autoinstaller to new one.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 407420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407420&action=review
> 
> > Tools/Scripts/webkitpy/__init__.py:32
> > +AutoInstall.register(Package('configparser', Version(4, 0, 2)))
> 
> configparser is being added here, but not being removed? Is it a new
> requirement? (same with wcwidth, zipp, zope etc.)
> 
> If we are adding new packages, it's better to do add in a separate patch,
> and keep this patch just to transition from old autoinstaller to new one.

The old installer was weirdly incomplete. All the packages being added here are dependencies of packages already added. Some of this may be because we're using newer versions (namely, Python 3 compatible ones), but some of this is probably because when we added the original dependencies on pytest, we didn't audit those packages fully to add their dependencies as well.

[Aakash Jain]

ok. rs=me

[Jonathan Bedard]

Created attachment 409324 [details]
Patch

[EWS]

Committed r267380: <https://trac.webkit.org/changeset/267380>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409324 [details].

[Truitt Savell]

Broke multiple test suites, reverted in https://trac.webkit.org/changeset/267410

[Jonathan Bedard]

Created attachment 410787 [details]
Patch

[Jonathan Bedard]

This was caused by the same issue I just fixed in https://bugs.webkit.org/show_bug.cgi?id=217438, so this should be safe to land again (basically, setuptools needs the wheel package)

[Aakash Jain]

rs=me

[EWS]

Committed r268267: <https://trac.webkit.org/changeset/268267>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410787 [details].