Bug 217826 - webkitpy: Sync package versions with WPT suite
Summary: webkitpy: Sync package versions with WPT suite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-16 07:53 PDT by Lauro Moura
Modified: 2020-10-30 05:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.21 KB, patch)
2020-10-29 21:49 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-10-16 07:53:28 PDT
Recently, packages version were updated in bug217650, bug217694 to get the WebDriver tests to work again after bug215895.

While this made most of the tests to work, there are still some small differences between the versions used in WPT and in WebKit, especially pytest (3.10 webkit vs 3.6 wpt), which may trigger changes in the test results.
Comment 1 Radar WebKit Bug Importer 2020-10-23 07:54:18 PDT
<rdar://problem/70619091>
Comment 2 Lauro Moura 2020-10-29 21:49:04 PDT
Created attachment 412711 [details]
Patch

funcsigs is 1.0.2 in webkitcorepy, while wpt uses 0.4. Would it be ok to downgrade it?
Comment 3 EWS 2020-10-30 05:32:14 PDT
Committed r269183: <https://trac.webkit.org/changeset/269183>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412711 [details].