Bug 214792 - [WebGL2] Update WebGL 2.0.0 conformance suite snapshot
Summary: [WebGL2] Update WebGL 2.0.0 conformance suite snapshot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 181293 214856
Blocks: 126404 189641 214893 214977
  Show dependency tree / graph
 
Reported: 2020-07-25 22:15 PDT by Kenneth Russell
Modified: 2020-07-30 10:56 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.06 MB, patch)
2020-07-27 16:18 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-07-25 22:15:24 PDT 
WebKit's snapshot of the WebGL 2.0.0 conformance suite was taken in 2018 in Bug 181293. Since then many bugs have been fixed in the conformance suite itself that were affecting correctness on some platforms, and on modern web browsers. A new snapshot is necessary to fix some current test timeouts and failures.

The conformance suite importing script in LayoutTests/webgl/generate-webgl-tests.py is being updated to handle snapshotting into a subdirectory, and is being run in the following way (while cd'd into LayoutTests/webgl):

python generate-webgl-tests.py -w ~/src/WebGL/conformance-suites/2.0.0 -o 2.0.0

in order to revise the snapshot without perturbing the expected text files.
Comment 1 Kenneth Russell 2020-07-27 16:18:17 PDT 
Created attachment 405325 [details]
Patch
Comment 2 Kenneth Russell 2020-07-27 18:36:19 PDT 
Comment on attachment 405325 [details]
Patch

Patch is passing all EWS bots - requesting CQ as well as review.
Comment 3 EWS 2020-07-28 11:03:12 PDT 
Committed r264997: <https://trac.webkit.org/changeset/264997>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405325 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-28 11:04:17 PDT 
<rdar://problem/66226821>