Bug 214893 - [ Mac ] webgl/2.0.0/ tests failing after r264997
Summary: [ Mac ] webgl/2.0.0/ tests failing after r264997
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 214792
Blocks: 126404
  Show dependency treegraph
 
Reported: 2020-07-28 13:23 PDT by Truitt Savell
Modified: 2020-07-28 14:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.60 KB, patch)
2020-07-28 13:45 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-07-28 13:23:16 PDT
Looks like after the update to webgl/2.0.0/ in https://trac.webkit.org/changeset/264997/webkit
We are seeing these new failures

webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer.html
webgl/2.0.0/conformance/uniforms/gl-uniform-arrays.html

history:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=webgl%2F2.0.0%2Fconformance2%2Frendering%2Fclear-srgb-color-buffer.html&test=webgl%2F2.0.0%2Fconformance%2Funiforms%2Fgl-uniform-arrays.html

I will add more that I find to this bug
Comment 1 Kenneth Russell 2020-07-28 13:28:01 PDT
webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer.html needs an increase to the tolerance.

webgl/2.0.0/conformance/uniforms/gl-uniform-arrays.html looks like a flaky timeout in Debug - needs to be marked Slow in Debug.
Comment 3 Kenneth Russell 2020-07-28 13:45:15 PDT
Created attachment 405404 [details]
Patch
Comment 4 Kenneth Russell 2020-07-28 13:46:15 PDT
The patch just uploaded should actually be the complete fix for this bug, so we can let the bug be closed by it. Let's please file any other regressions under a new bug - thanks.
Comment 5 EWS 2020-07-28 14:20:22 PDT
Committed r265007: <https://trac.webkit.org/changeset/265007>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405404 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-28 14:21:24 PDT
<rdar://problem/66237181>