Bug 213979 - REGRESSION(r263953): Broke internal build
Summary: REGRESSION(r263953): Broke internal build
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
Keywords: InRadar
Depends on: 213980
Blocks: 212542 213976 233304
  Show dependency treegraph
Reported: 2020-07-05 17:45 PDT by Yusuke Suzuki
Modified: 2021-11-17 20:56 PST (History)
3 users (show)

See Also:

REVERT of r263953 (101.19 KB, patch)
2020-07-05 17:45 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-07-05 17:45:02 PDT
https://trac.webkit.org/changeset/263953 broke the build:
Broke internal build

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 Yusuke Suzuki 2020-07-05 17:45:12 PDT
Created attachment 403567 [details]
REVERT of r263953

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2020-07-05 17:46:22 PDT
Committed r263960: <https://trac.webkit.org/changeset/263960>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403567 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-05 17:47:17 PDT
Comment 4 Yusuke Suzuki 2020-07-05 17:58:18 PDT
Re-opened since this is blocked by bug 213980
Comment 5 Alexey Proskuryakov 2020-07-05 17:59:11 PDT
Re-landing these revisions, because together, they don't break the build somehow.