Bug 213976 - [Cocoa] Remove FEATURE_DEFINES from the Cocoa/Xcode build system
Summary: [Cocoa] Remove FEATURE_DEFINES from the Cocoa/Xcode build system
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on: 213979
Blocks: 233304
  Show dependency tree / graph
 
Reported: 2020-07-05 12:47 PDT by Darin Adler
Modified: 2021-11-17 20:56 PST (History)
11 users (show)

See Also:

Attachments
Patch (48.20 KB, patch)
2020-07-05 12:57 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-07-05 12:47:47 PDT 
[Cocoa] Remove FEATURE_DEFINES from the Cocoa/Xcode build system
Comment 1 Darin Adler 2020-07-05 12:57:01 PDT 
Created attachment 403562 [details]
Patch
Comment 2 Sam Weinig 2020-07-05 14:50:42 PDT 
Comment on attachment 403562 [details]
Patch

Victory!
Comment 3 Darin Adler 2020-07-05 16:34:17 PDT 
Committed r263959: <https://trac.webkit.org/changeset/263959>
Comment 4 Radar WebKit Bug Importer 2020-07-05 16:35:13 PDT 
<rdar://problem/65112494>
Comment 5 Yusuke Suzuki 2020-07-05 17:45:06 PDT 
Re-opened since this is blocked by bug 213979
Comment 6 Alexey Proskuryakov 2020-07-05 17:59:36 PDT 
Re-landing via bug 213980.