Bug 213980 - REGRESSION(r263960): Re-land, because r263959 somehow fixed the build issue caused by r263953
Summary: REGRESSION(r263960): Re-land, because r263959 somehow fixed the build issue c...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
Keywords: InRadar
Depends on:
Blocks: 213979 233304
  Show dependency treegraph
Reported: 2020-07-05 17:58 PDT by Yusuke Suzuki
Modified: 2021-11-17 20:44 PST (History)
3 users (show)

See Also:

REVERT of r263960 (99.76 KB, patch)
2020-07-05 17:58 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-07-05 17:58:16 PDT
https://trac.webkit.org/changeset/263960 broke the build:
Re-land, because r263959 somehow fixed the build issue caused by r263953

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 Yusuke Suzuki 2020-07-05 17:58:24 PDT
Created attachment 403568 [details]
REVERT of r263960

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2020-07-05 17:59:34 PDT
Committed r263961: <https://trac.webkit.org/changeset/263961>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403568 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-05 18:00:32 PDT
Comment 4 Darin Adler 2020-07-05 18:57:44 PDT
OK, some notes for the record on what I figured out after the fact.

The reason that r263953 broke Apple's internal builds is that there was a bug in the DerivedSources.make files where FEATURE_DEFINE_FLAGS would incorrect be defined as "-D" if FEATURE_DEFINES was empty. The reason that FEATURE_DEFINES was empty on the internal builds after r263953 is that the only feature left there was ENABLE_EXPERIMENTAL_FEATURES. That was enabled for builds on individual engineer’s computers, and the open source builds, but not for Apple internal production builds.

The reason that r263959 made the problem go away is that it deleted FEATURE_DEFINE_FLAGS entirely, taking the bug with it.