Bug 212542 - [Cocoa] Move almost all features from FeatureDefines.xcconfig to PlatformEnableCocoa.h
Summary: [Cocoa] Move almost all features from FeatureDefines.xcconfig to PlatformEnab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on: 212420 213962 213964 213979
Blocks: 213949
  Show dependency tree / graph
 
Reported: 2020-05-29 13:56 PDT by Darin Adler
Modified: 2020-07-05 17:59 PDT (History)
16 users (show)

See Also:

Attachments
Patch (93.01 KB, patch)
2020-05-29 13:58 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (91.71 KB, patch)
2020-05-29 18:18 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (63.03 KB, patch)
2020-07-04 19:02 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (65.73 KB, patch)
2020-07-04 19:45 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-05-29 13:56:36 PDT 
Move almost all features from FeatureDefines.xcconfig to PlatformEnableCocoa.h
Comment 1 Darin Adler 2020-05-29 13:58:21 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2020-05-29 18:18:52 PDT Comment hidden (obsolete)
Comment 3 Darin Adler 2020-07-04 19:02:04 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2020-07-04 19:05:08 PDT 
I think there will be more cleanup possible after this; seems we should remove the files entirely. The EXPERIMENTAL_FEATURES switching is specific to the WebKit framework, and doesn’t need to be done in all the other projects.
Comment 5 Darin Adler 2020-07-04 19:45:44 PDT 
Created attachment 403543 [details]
Patch
Comment 6 Darin Adler 2020-07-05 12:32:02 PDT 
Committed r263953: <https://trac.webkit.org/changeset/263953>
Comment 7 Radar WebKit Bug Importer 2020-07-05 12:33:20 PDT 
<rdar://problem/65109960>
Comment 8 Yusuke Suzuki 2020-07-05 17:45:04 PDT 
Re-opened since this is blocked by bug 213979
Comment 9 Alexey Proskuryakov 2020-07-05 17:59:26 PDT 
Re-landing via bug 213980.