Bug 205335 - [GTK][WPE] Enable WebGL by default
Summary: [GTK][WPE] Enable WebGL by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-17 06:30 PST by Michael Catanzaro
Modified: 2020-01-21 03:28 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2020-01-21 01:10 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-12-17 06:30:13 PST 
I noticed WebGL is still disabled by default. This is weird since it's been mature for a long time now. I would flip the default similarly to how we enabled MSE in bug #190243.

Note: bug #69706 attempted to do this, but failed because there's also a runtime setting.
Comment 1 Carlos Garcia Campos 2020-01-21 01:10:59 PST 
Created attachment 388286 [details]
Patch
Comment 2 EWS Watchlist 2020-01-21 01:12:07 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Adrian Perez 2020-01-21 02:00:09 PST 
Comment on attachment 388286 [details]
Patch

Patch LGTM, but let's fix the indentation issue reported by
the style checker while at it before commiting :)
Comment 4 Adrian Perez 2020-01-21 02:00:55 PST 
Oh, and for the record I agree that it seems like
a very good idea to have WebGL enabled by default.
Comment 5 Carlos Garcia Campos 2020-01-21 03:28:18 PST 
Committed r254848: <https://trac.webkit.org/changeset/254848>