Bug 190243 - [WPE][GTK] Enable MSE by default
Summary: [WPE][GTK] Enable MSE by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-03 03:02 PDT by Michael Catanzaro
Modified: 2018-10-03 06:06 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2018-10-03 03:09 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-10-03 03:02:49 PDT 
Enable MSE by default

Changing the default value of features is kinda an API change, but surely this is allowed.
Comment 1 Michael Catanzaro 2018-10-03 03:09:12 PDT 
Created attachment 351503 [details]
Patch
Comment 2 EWS Watchlist 2018-10-03 03:11:03 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alicia Boya García 2018-10-03 03:39:34 PDT 
There are still features we don't support, but it already works with popular players and it's already enabled in Epiphany, so I'm OK with this.
Comment 4 Xabier Rodríguez Calvar 2018-10-03 05:40:48 PDT 
Comment on attachment 351503 [details]
Patch

I'm letting Alicia hit the enter key or mouse button here :)
Comment 5 WebKit Commit Bot 2018-10-03 06:06:28 PDT 
Comment on attachment 351503 [details]
Patch

Clearing flags on attachment: 351503

Committed r236793: <https://trac.webkit.org/changeset/236793>
Comment 6 WebKit Commit Bot 2018-10-03 06:06:29 PDT 
All reviewed patches have been landed.  Closing bug.