Bug 205334 - [GTK][WPE] Enable WebAudio by default
Summary: [GTK][WPE] Enable WebAudio by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-17 06:28 PST by Michael Catanzaro
Modified: 2020-01-21 03:15 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.60 KB, patch)
2020-01-21 01:06 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-12-17 06:28:43 PST 
I noticed WebAudio is still disabled by default. This is weird since it's been mature for a long time now. I would flip the default similarly to how we enabled MSE in bug #190243.
Comment 1 Carlos Garcia Campos 2020-01-21 01:06:33 PST 
Created attachment 388285 [details]
Patch
Comment 2 EWS Watchlist 2020-01-21 01:08:15 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Adrian Perez 2020-01-21 02:06:46 PST 
Comment on attachment 388285 [details]
Patch

LGTM, but please make the style checker pass before landing :)
Comment 4 Carlos Garcia Campos 2020-01-21 03:15:12 PST 
Committed r254847: <https://trac.webkit.org/changeset/254847>