Bug 203949 - REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html
Summary: REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-07 05:43 PST by Aakash Jain
Modified: 2019-11-08 16:22 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.52 KB, patch)
2019-11-07 13:23 PST, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-07 05:43:31 PST
The changes in https://trac.webkit.org/changeset/252121/webkit is causing the test webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html to timeout consistently.

Its expectation for mac/gtk/wpe is slow, e.g.: https://trac.webkit.org/browser/webkit/trunk/LayoutTests/platform/mac/TestExpectations#L401

However it is consistently timing out on all platforms: https://results.webkit.org/?suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-non-reserved-words.html

Results: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r252180%20(6765)/results.html
Comment 1 Aakash Jain 2019-11-07 05:44:56 PST
This is also slowing mac mac-debug-wk1 ews. e.g.: https://ews-build.webkit.org/#/builders/17/builds/5961
Comment 2 Radar WebKit Bug Importer 2019-11-07 05:45:00 PST
<rdar://problem/56979888>
Comment 3 Justin Fan 2019-11-07 13:23:15 PST
Created attachment 383068 [details]
Patch
Comment 4 Justin Fan 2019-11-07 13:34:21 PST
Comment on attachment 383068 [details]
Patch

Clearing flags on attachment: 383068

Committed r252204: <https://trac.webkit.org/changeset/252204>
Comment 5 Justin Fan 2019-11-07 13:34:22 PST
All reviewed patches have been landed.  Closing bug.