Bug 203763 - [WebGL] Update WebGL 1 tests to prep for WebGL Conformance bot
Summary: [WebGL] Update WebGL 1 tests to prep for WebGL Conformance bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
: 203766 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-11-01 14:47 PDT by Justin Fan
Modified: 2019-11-07 14:18 PST (History)
5 users (show)

See Also:


Attachments
WIP Patch for size concern (10.87 MB, patch)
2019-11-03 22:42 PST, Justin Fan
no flags Details | Formatted Diff | Diff
WIP patch for size concern (11.21 MB, patch)
2019-11-03 23:00 PST, Justin Fan
dino: review+
Details | Formatted Diff | Diff
Patch for landing (10.73 MB, patch)
2019-11-04 16:09 PST, Justin Fan
no flags Details | Formatted Diff | Diff
Patch for landing (11.06 MB, patch)
2019-11-04 16:10 PST, Justin Fan
no flags Details | Formatted Diff | Diff
Patch w/ Changelog (11.06 MB, patch)
2019-11-05 14:25 PST, Justin Fan
no flags Details | Formatted Diff | Diff
Patch attempt (11.06 MB, patch)
2019-11-05 15:57 PST, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-11-01 14:47:42 PDT
[WebGL] Update WebGL 1 tests to prep for WebGL Conformance bot
Comment 1 Justin Fan 2019-11-01 15:02:34 PDT
*** Bug 203766 has been marked as a duplicate of this bug. ***
Comment 2 Justin Fan 2019-11-03 22:42:19 PST
Created attachment 382717 [details]
WIP Patch for size concern
Comment 3 Justin Fan 2019-11-03 23:00:48 PST
Created attachment 382718 [details]
WIP patch for size concern
Comment 4 Justin Fan 2019-11-03 23:13:45 PST
Diff is so large patch is timing out. Yay
Comment 5 Dean Jackson 2019-11-04 13:38:51 PST
rs=me
Comment 6 Justin Fan 2019-11-04 16:09:52 PST
Created attachment 382783 [details]
Patch for landing
Comment 7 Justin Fan 2019-11-04 16:10:24 PST
Created attachment 382784 [details]
Patch for landing
Comment 8 Justin Fan 2019-11-05 14:25:26 PST
Created attachment 382850 [details]
Patch w/ Changelog
Comment 9 Justin Fan 2019-11-05 15:57:38 PST
Created attachment 382856 [details]
Patch attempt
Comment 10 Justin Fan 2019-11-05 17:03:00 PST
<rdar://problem/44468535>
Comment 11 Justin Fan 2019-11-05 19:01:45 PST
Committed r252121: <https://trac.webkit.org/changeset/252121>
Comment 12 Truitt Savell 2019-11-06 08:41:59 PST
The changes in https://trac.webkit.org/changeset/252121/webkit

Broke several tests on iOS and introduced failing tests.
11 failing tests:

webgl/1.0.3/conformance/extensions/get-extension.html
webgl/1.0.3/conformance/extensions/oes-texture-float.html
webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit.html
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html
webgl/1.0.3/conformance/more/functions/readPixelsBadArgs.html
webgl/1.0.3/conformance/more/functions/texImage2DHTML.html
webgl/1.0.3/conformance/more/functions/texSubImage2DHTML.html
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html
webgl/1.0.3/conformance/textures/texture-npot-video.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fget-extension.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Foes-texture-float.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-compressed-texture-size-limit.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-draw-buffers.html&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-reserved-words.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FreadPixelsBadArgs.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexSubImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Frenderbuffers%2Fframebuffer-object-attachment.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Fcopy-tex-image-2d-formats.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Ftexture-npot-video.html&platform=ios
Comment 13 Truitt Savell 2019-11-06 08:50:15 PST
These two are also failing or timing out on Mac:

webgl/1.0.3/conformance/textures/texture-npot-video.html
webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html
Comment 14 Aakash Jain 2019-11-06 11:40:42 PST
webgl/1.0.3/conformance/context/context-release-upon-reload.html seems flaky, in https://ews-build.webkit.org/#/builders/17/builds/5817 , it passed in layout-tests step, but failed in re-run-layout-tests step.
Comment 15 Justin Fan 2019-11-07 14:18:20 PST
<rdar://problem/44468535>