Bug 203908 - REGRESSION: r252121 introduced new webgl/ failures
Summary: REGRESSION: r252121 introduced new webgl/ failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2019-11-06 11:24 PST by Truitt Savell
Modified: 2019-11-07 05:46 PST (History)
13 users (show)

See Also:


Attachments
WIP patch for mac side and EWS (5.15 KB, patch)
2019-11-06 13:12 PST, Justin Fan
no flags Details | Formatted Diff | Diff
Patch for landing (3.33 KB, patch)
2019-11-06 13:32 PST, Justin Fan
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-highsierra (3.36 MB, application/zip)
2019-11-06 15:30 PST, WebKit Commit Bot
no flags Details
Please land this patch (3.40 KB, patch)
2019-11-06 17:50 PST, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-11-06 11:24:01 PST
The changes in https://trac.webkit.org/changeset/252121/webkit

Broke several tests on iOS and introduced failing tests.
11 failing tests:

webgl/1.0.3/conformance/extensions/get-extension.html
webgl/1.0.3/conformance/extensions/oes-texture-float.html
webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit.html
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html
webgl/1.0.3/conformance/more/functions/readPixelsBadArgs.html
webgl/1.0.3/conformance/more/functions/texImage2DHTML.html
webgl/1.0.3/conformance/more/functions/texSubImage2DHTML.html
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html
webgl/1.0.3/conformance/textures/texture-npot-video.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fget-extension.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Foes-texture-float.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-compressed-texture-size-limit.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-draw-buffers.html&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-reserved-words.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FreadPixelsBadArgs.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexSubImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Frenderbuffers%2Fframebuffer-object-attachment.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Fcopy-tex-image-2d-formats.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Ftexture-npot-video.html&platform=ios

Results:
https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r252136%20(761)/results.html
Comment 1 Radar WebKit Bug Importer 2019-11-06 11:24:34 PST
<rdar://problem/56951561>
Comment 2 Justin Fan 2019-11-06 13:12:00 PST
Created attachment 382951 [details]
WIP patch for mac side and EWS
Comment 3 Justin Fan 2019-11-06 13:32:48 PST
Created attachment 382956 [details]
Patch for landing
Comment 4 Justin Fan 2019-11-06 13:34:37 PST
Just going to mark them as failing for now. Followup bug/patch later today to add new baselines.
Comment 5 Justin Fan 2019-11-06 15:04:05 PST
Seeing some extra failures. WebGL tends to be finicky based on Intel vs AMD, different GPUs, etc. ugh.
Comment 6 WebKit Commit Bot 2019-11-06 15:30:28 PST
Comment on attachment 382956 [details]
Patch for landing

Rejecting attachment 382956 [details] from commit-queue.

New failing tests:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Full output: https://webkit-queues.webkit.org/results/13220282
Comment 7 WebKit Commit Bot 2019-11-06 15:30:29 PST
Created attachment 382968 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 Justin Fan 2019-11-06 17:50:34 PST
Created attachment 382992 [details]
Please land this patch
Comment 9 Aakash Jain 2019-11-06 17:55:09 PST
Comment on attachment 382992 [details]
Please land this patch

Clearing flags on attachment: 382992

Committed r252164: <https://trac.webkit.org/changeset/252164>
Comment 10 Aakash Jain 2019-11-06 17:55:13 PST
All reviewed patches have been landed.  Closing bug.