Bug 203908 – REGRESSION: r252121 introduced new webgl/ failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Truitt Savell]

The changes in https://trac.webkit.org/changeset/252121/webkit

Broke several tests on iOS and introduced failing tests.
11 failing tests:

webgl/1.0.3/conformance/extensions/get-extension.html
webgl/1.0.3/conformance/extensions/oes-texture-float.html
webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit.html
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html
webgl/1.0.3/conformance/more/functions/readPixelsBadArgs.html
webgl/1.0.3/conformance/more/functions/texImage2DHTML.html
webgl/1.0.3/conformance/more/functions/texSubImage2DHTML.html
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html
webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html
webgl/1.0.3/conformance/textures/texture-npot-video.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fget-extension.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Foes-texture-float.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-compressed-texture-size-limit.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-draw-buffers.html&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-reserved-words.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FreadPixelsBadArgs.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexSubImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Frenderbuffers%2Fframebuffer-object-attachment.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Fcopy-tex-image-2d-formats.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Ftexture-npot-video.html&platform=ios

Results:
https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r252136%20(761)/results.html

[Radar WebKit Bug Importer]

<rdar://problem/56951561>

[Justin Fan]

Created attachment 382951 [details]
WIP patch for mac side and EWS

[Justin Fan]

Created attachment 382956 [details]
Patch for landing

[Justin Fan]

Just going to mark them as failing for now. Followup bug/patch later today to add new baselines.

[Justin Fan]

Seeing some extra failures. WebGL tends to be finicky based on Intel vs AMD, different GPUs, etc. ugh.

[WebKit Commit Bot]

Comment on attachment 382956 [details]
Patch for landing

Rejecting attachment 382956 [details] from commit-queue.

New failing tests:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Full output: https://webkit-queues.webkit.org/results/13220282

[WebKit Commit Bot]

Created attachment 382968 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Justin Fan]

Created attachment 382992 [details]
Please land this patch

[Aakash Jain]

Comment on attachment 382992 [details]
Please land this patch

Clearing flags on attachment: 382992

Committed r252164: <https://trac.webkit.org/changeset/252164>

[Aakash Jain]

All reviewed patches have been landed.  Closing bug.