Bug 203984 – webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Aakash Jain]

webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky on High Sierra Debug WK1.

History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fcontext%2Fcontext-release-upon-reload.html

e.g.: it flaked in https://ews-build.webkit.org/#/builders/17/builds/5974 , it crashed in   layout-tests step, but passed in re-run-layout-tests step.


Possible regression from https://trac.webkit.org/changeset/252121/webkit.

[Radar WebKit Bug Importer]

<rdar://problem/57004328>

[Justin Fan]

Created attachment 383094 [details]
Patch

[Justin Fan]

Comment on attachment 383094 [details]
Patch

Clearing flags on attachment: 383094

Committed r252222: <https://trac.webkit.org/changeset/252222>

[Justin Fan]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Re-opening, because this patch only skipped the test.

Also the same test in 2.0.0 directory crashes too: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r252185%20(11696)/results.html

Are these even really entirely separate test suites?

ASSERTION FAILED: !needsLayout()
./rendering/RenderView.cpp(306) : virtual void WebCore::RenderView::paint(WebCore::PaintInfo &, const WebCore::LayoutPoint &)
1   0x10ea0cf29 WTFCrash
2   0x11b04997b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x11ea60c3b WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
4   0x11e918303 WebCore::RenderLayer::paintBackgroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
5   0x11e914bc0 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
6   0x11e9365bc WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_10::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const
7   0x11e935fa7 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)
8   0x11e937acc WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
9   0x11e3b9462 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
10  0x11e42d52c WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
11  0x11c5bdea5 WebCore::PlatformCALayer::drawLayerContents(CGContext*, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul>&, unsigned int)
12  0x11c6fee23 -[WebLayer drawInContext:]
13  0x7fff55ef0556 CABackingStoreUpdate_
14  0x7fff55ef041b invocation function for block in CA::Layer::display_()
15  0x7fff55eefcb2 -[CALayer _display]
16  0x11c6ff3eb -[WebSimpleLayer display]
17  0x7fff55ee0e29 CA::Layer::display_if_needed(CA::Transaction*)
18  0x7fff55ee08e7 CA::Layer::layout_and_display_if_needed(CA::Transaction*)
19  0x7fff55edf8d8 CA::Context::commit_transaction(CA::Transaction*)
20  0x7fff55edf475 CA::Transaction::commit()
21  0x7fff55eeb8ca CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*)
22  0x7fff4ab6df87 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
23  0x7fff4ab6deaf __CFRunLoopDoObservers
24  0x7fff4ab50ae0 __CFRunLoopRun
25  0x7fff4ab50207 CFRunLoopRunSpecific
26  0x10b48df69 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
27  0x10b48bfff runTestingServerLoop()
28  0x10b48b48e dumpRenderTree(int, char const**)
29  0x10b48e9ff DumpRenderTreeMain(int, char const**)
30  0x10b523162 main
31  0x7fff72aff015 start

[Justin Fan]

They are separate test suites because the tests under 2.0.0 are meant to be run with a WebGL 2 context as opposed to a WebGL 1 context.

[Alexey Proskuryakov]

Are we running them with a WebGL 2 context in practice now?

[Aakash Jain]

This is still crashing sometimes.
e.g.:
https://ews-build.webkit.org/#/builders/17/builds/6931
https://ews-build.webkit.org/#/builders/17/builds/6786
https://ews-build.webkit.org/#/builders/17/builds/6776

[Aakash Jain]

From https://ews-build.webkit.org/results/macOS-High-Sierra-Debug-WK1-Tests-EWS/r383904-6931/results.html

Application Specific Information:
CRASHING TEST: webgl/2.0.0/conformance/context/context-release-upon-reload.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x000000010127bd80 WTFCrash + 16
1   com.apple.WebCore             	0x000000010f895b0b WTFCrashWithInfo(int, char const*, char const*, int) + 27
2   com.apple.WebCore             	0x000000011327267b WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) + 123
3   com.apple.WebCore             	0x000000011312f8d3 WebCore::RenderLayer::paintBackgroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) + 595
4   com.apple.WebCore             	0x000000011312c190 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) + 3184
5   com.apple.WebCore             	0x000000011314db8c WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_10::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const + 396
6   com.apple.WebCore             	0x000000011314d577 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*) + 375
7   com.apple.WebCore             	0x000000011314f09c WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) + 748
8   com.apple.WebCore             	0x0000000112bd22c2 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) + 258
9   com.apple.WebCore             	0x0000000112c4637c WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) + 1628
10  com.apple.WebCore             	0x0000000110e0f065 WebCore::PlatformCALayer::drawLayerContents(CGContext*, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul>&, unsigned int) + 901
11  com.apple.WebCore             	0x0000000110f59403 -[WebLayer drawInContext:] + 163
12  com.apple.QuartzCore          	0x00007fff4b02d556 CABackingStoreUpdate_ + 300
13  com.apple.QuartzCore          	0x00007fff4b02d41b invocation function for block in CA::Layer::display_() + 53
14  com.apple.QuartzCore          	0x00007fff4b02ccb2 -[CALayer _display] + 2238
15  com.apple.WebCore             	0x0000000110f599cb -[WebSimpleLayer display] + 139
16  com.apple.QuartzCore          	0x00007fff4b01de29 CA::Layer::display_if_needed(CA::Transaction*) + 633
17  com.apple.QuartzCore          	0x00007fff4b01d8e7 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 35
18  com.apple.QuartzCore          	0x00007fff4b01c8d8 CA::Context::commit_transaction(CA::Transaction*) + 326
19  com.apple.QuartzCore          	0x00007fff4b01c475 CA::Transaction::commit() + 487
20  com.apple.QuartzCore          	0x00007fff4b0288ca CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*) + 66
21  com.apple.CoreFoundation      	0x00007fff3fcaaf87 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23
22  com.apple.CoreFoundation      	0x00007fff3fcaaeaf __CFRunLoopDoObservers + 511
23  com.apple.CoreFoundation      	0x00007fff3fc8dae0 __CFRunLoopRun + 1600
24  com.apple.CoreFoundation      	0x00007fff3fc8d207 CFRunLoopRunSpecific + 487
25  DumpRenderTree                	0x000000010007c0e9 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 7865 (DumpRenderTree.mm:2104)

[Justin Fan]

Skipping for now. We will reset all test expecations soon after ANGLE backend switch, at which point this will be revisited.

[Justin Fan]

Created attachment 383980 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383980 [details]
Patch

Clearing flags on attachment: 383980

Committed r252715: <https://trac.webkit.org/changeset/252715>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.