Bug 203743 – Web Inspector: default to focusing the console prompt if no other content is focused after opening Web Inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

If the user is looking at the Canvas Tab, for example, there is no preserved selection/focused state between Web Inspector sessions, so if the user opens Web Inspector to the Canvas Tab, there will be no initial focus.

[Devin Rousso]

Created attachment 382590 [details]
Patch

[Eric Carlson]

Comment on attachment 382590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382590&action=review

Thank you!

> Source/WebInspectorUI/UserInterface/Base/Main.js:925
> +    return !WI._defaultFocusedQuickConcolePrompt && WI.quickConsole.prompt.focused;

Nit: s/_defaultFocusedQuickConcolePrompt/_defaultFocusedQuickConsolePrompt/

> Source/WebInspectorUI/UserInterface/Base/Main.js:1364
> +    WI._defaultFocusedQuickConcolePrompt = false;

Ditto.

> Source/WebInspectorUI/UserInterface/Base/Main.js:1546
> +        WI._defaultFocusedQuickConcolePrompt = true;

Ditto

[Blaze Burg]

Comment on attachment 382590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382590&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:925
> +    return !WI._defaultFocusedQuickConcolePrompt && WI.quickConsole.prompt.focused;

Typo: console

A better name could be: WI._didAutofocusConsolePrompt

[Devin Rousso]

Created attachment 382619 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 382619 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 382619 [details]:

imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg bug 203172 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 382619 [details]
Patch

Rejecting attachment 382619 [details] from commit-queue.

New failing tests:
requestidlecallback/requestidlecallback-document-gc.html
Full output: https://webkit-queues.webkit.org/results/13202266

[WebKit Commit Bot]

Created attachment 382638 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Devin Rousso]

Created attachment 382648 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382648 [details]
Patch

Clearing flags on attachment: 382648

Committed r251958: <https://trac.webkit.org/changeset/251958>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56833461>