Bug 203744 – Web Inspector: switching tabs should re-focus the previously focused element

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. select any item in the navigation sidebar of the Storage Tab
3. go to a different tab
4. go back to the Storage Tab
 => item selected in step #2 is no longer focused

[Devin Rousso]

Created attachment 382591 [details]
Patch

[Blaze Burg]

Comment on attachment 382591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382591&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:317
> +        if (treeElement)

We still want selectedByUser = false, otherwise this will cause an extra history entry in the back/forward for the content area.

[Devin Rousso]

Comment on attachment 382591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382591&action=review

>> Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:317
>> +        if (treeElement)
> 
> We still want selectedByUser = false, otherwise this will cause an extra history entry in the back/forward for the content area.

`selectedByUser` defaults to `false` if not provided (both due to the fact that `undefined` is falsy and that `WI.TreeOutline.prototype.selectTreeElementInternal` has an optional parameter) so the only change here should be to `omitFocus`.

[WebKit Commit Bot]

Comment on attachment 382591 [details]
Patch

Clearing flags on attachment: 382591

Committed r251962: <https://trac.webkit.org/changeset/251962>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56834780>