Bug 203932 – Web Inspector: REGRESSION(r251958): console prompt is automatically focused when page is reloaded

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Timelines Tab
3. select something in the Timelines Tab (e.g. a record row in the table)
4. reload the page
 => console prompt becomes focused

[Devin Rousso]

Created attachment 382987 [details]
Patch

[Timothy Hatcher]

Comment on attachment 382987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382987&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:1565
> +    if (WI._didAutofocusConsolePrompt === undefined) {

!WI._didAutofocusConsolePrompt

[Devin Rousso]

Comment on attachment 382987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382987&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:1565
>> +    if (WI._didAutofocusConsolePrompt === undefined) {
> 
> !WI._didAutofocusConsolePrompt

I actually specifically want to use `undefined` because it's set to `false` inside `WI._focusChanged`.

[WebKit Commit Bot]

Comment on attachment 382987 [details]
Patch

Rejecting attachment 382987 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 382987, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=382987&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=203932&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 382987 from bug 203932.
Fetching: https://bugs.webkit.org/attachment.cgi?id=382987
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebInspectorUI/UserInterface/Base/Main.js
Hunk #1 FAILED at 1561.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Base/Main.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13223707

[Devin Rousso]

Created attachment 383079 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383079 [details]
Patch

Clearing flags on attachment: 383079

Committed r252213: <https://trac.webkit.org/changeset/252213>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57001696>