Bug 203701 – Python 3: Add support in webkitpy.layout_tests

• Status: NEW
• Component: Tools / Tests

[Jonathan Bedard]

Work towards allowing run-webkit-tests to be run with Python3.

[Michael Catanzaro]

*** Bug 210699 has been marked as a duplicate of this bug. ***

[Michael Catanzaro]

From bug #210699:

$ ./Tools/Scripts/run-webkit-tests --verbose --debug LayoutTests/fast/css/getComputedStyle/computed-style.html                                                                                                                             
Using port 'gtk-wk2'
Test configuration: <, x86, debug>
Placing test results in /home/emilio/src/WebKit/WebKitBuild/Debug/layout-test-results
Using Debug build
Pixel tests disabled
Regular timeout: 30000, slow test timeout: 150000
Command line: /home/emilio/src/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner -

Found 1 test; running 1, skipping 0.
                  
Verbose baseline search path: platform/gtk -> platform/wk2 -> generic

Baseline search path: platform/gtk -> platform/wk2 -> generic

Running 1 test

Checking system dependencies ...
TypeError raised: argument should be integer or bytes-like object, not 'str'
Traceback (most recent call last):
  File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 91, in main
    run_details = run(port, options, args, stderr)
  File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 487, in run
    run_details = manager.run(args)
  File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 270, in run
    if not self._set_up_run(tests_to_run_by_device[device_type], device_type=device_type):
  File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 176, in _set_up_run
    self._port.setup_test_run(device_type)
  File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 108, in setup_test_run
    self._pulseaudio_sanitizer.unload_pulseaudio_module()
  File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/pulseaudio_sanitizer.py", line 58, in unload_pulseaudio_module
    if module.find("module-stream-restore") >= 0:
TypeError: argument should be integer or bytes-like object, not 'str'

[Jonathan Bedard]

Not a code-path (In reply to Michael Catanzaro from comment #2)
> From bug #210699:
> 
> $ ./Tools/Scripts/run-webkit-tests --verbose --debug
> LayoutTests/fast/css/getComputedStyle/computed-style.html                   
> 
> Using port 'gtk-wk2'
> Test configuration: <, x86, debug>
> Placing test results in
> /home/emilio/src/WebKit/WebKitBuild/Debug/layout-test-results
> Using Debug build
> Pixel tests disabled
> Regular timeout: 30000, slow test timeout: 150000
> Command line: /home/emilio/src/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner
> -
> 
> Found 1 test; running 1, skipping 0.
>                   
> Verbose baseline search path: platform/gtk -> platform/wk2 -> generic
> 
> Baseline search path: platform/gtk -> platform/wk2 -> generic
> 
> Running 1 test
> 
> Checking system dependencies ...
> TypeError raised: argument should be integer or bytes-like object, not 'str'
> Traceback (most recent call last):
>   File
> "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/
> run_webkit_tests.py", line 91, in main
>     run_details = run(port, options, args, stderr)
>   File
> "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/
> run_webkit_tests.py", line 487, in run
>     run_details = manager.run(args)
>   File
> "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/
> manager.py", line 270, in run
>     if not self._set_up_run(tests_to_run_by_device[device_type],
> device_type=device_type):
>   File
> "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/
> manager.py", line 176, in _set_up_run
>     self._port.setup_test_run(device_type)
>   File "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line
> 108, in setup_test_run
>     self._pulseaudio_sanitizer.unload_pulseaudio_module()
>   File
> "/home/emilio/src/WebKit/Tools/Scripts/webkitpy/port/pulseaudio_sanitizer.
> py", line 58, in unload_pulseaudio_module
>     if module.find("module-stream-restore") >= 0:
> TypeError: argument should be integer or bytes-like object, not 'str'

I don't have a machine which exercises this code path, the fix is not likely to be difficult, but it's also likely there are multiple encoding problems in that class.

[Philippe Normand]

If that's the only issue, the fix is easy. I'll check it.

[Jonathan Bedard]

Created attachment 418548 [details]
Patch

[Jonathan Bedard]

(In reply to Jonathan Bedard from comment #5)
> Created attachment 418548 [details]
> Patch

That's a blind fix for the raised exception

[Philippe Normand]

bug 223888 removes that pulseaudio thing BTW :)

[Philippe Normand]

What's the status here?

Just trying now to run the WPE layout tests in Python3, the test harness no longer spits a traceback and tests actually seem to run.

[Jonathan Bedard]

(In reply to Philippe Normand from comment #8)
> What's the status here?
> 
> Just trying now to run the WPE layout tests in Python3, the test harness no
> longer spits a traceback and tests actually seem to run.

The test runner works in 3.7, still has some issues in 3.8 which I will be working on this week and next (issues are about forking)

[Philippe Normand]

Here in linux with python 3.8.7 the only issue I noticed so far was that tests expected to time out were detected as unexpected timeouts.

[Radar WebKit Bug Importer]

<rdar://problem/77321491>

[Sam Sneddon [:gsnedders]]

(In reply to Jonathan Bedard from comment #9)
> (In reply to Philippe Normand from comment #8)
> > What's the status here?
> > 
> > Just trying now to run the WPE layout tests in Python3, the test harness no
> > longer spits a traceback and tests actually seem to run.
> 
> The test runner works in 3.7, still has some issues in 3.8 which I will be
> working on this week and next (issues are about forking)

Note that the change of the multiprocessing default start method in 3.8 was only on macOS; non-macOS Unix systems still use the fork start method, and Windows has for a long time used the spawn start method. As such, as Philippe says, I would be surprised by changes in behaviour between 3.7 and 3.8 on Linux.

Also, given the WinCairo test bot isn't totally broken, presumably whatever is causing issues with the spawn start method is something related to the Darwin ports?

[Philippe Normand]

Python2 is still used for the WebSocket server. WIP patch in bug 222188.