Bug 203702 - Python 3: Add support in webkitpy.layout_tests.model
Summary: Python 3: Add support in webkitpy.layout_tests.model
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-31 16:18 PDT by Jonathan Bedard
Modified: 2019-11-01 18:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.37 KB, patch)
2019-10-31 16:27 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (10.32 KB, patch)
2019-10-31 17:54 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (12.39 KB, patch)
2019-11-01 09:24 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (12.39 KB, patch)
2019-11-01 17:08 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-10-31 16:18:34 PDT 
Note that in this directory, occasionally, we need to opt into using iterators in both Python 2 and 3 because we have 60,000+ tests.
Comment 1 Jonathan Bedard 2019-10-31 16:27:59 PDT 
Created attachment 382516 [details]
Patch
Comment 2 Stephanie Lewis 2019-10-31 16:31:24 PDT 
Comment on attachment 382516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382516&action=review

otherwise good

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:-569
> -        for test, modifiers in self._test_to_modifiers.iteritems():

can we make a compatibility function here as well.
Comment 3 Jonathan Bedard 2019-10-31 17:54:47 PDT 
Created attachment 382530 [details]
Patch
Comment 4 Stephanie Lewis 2019-10-31 19:22:47 PDT 
Comment on attachment 382530 [details]
Patch

Either I'm blind or you forgot to include the iteration_compatibility file
Comment 5 Jonathan Bedard 2019-11-01 09:24:22 PDT 
Created attachment 382586 [details]
Patch
Comment 6 Jonathan Bedard 2019-11-01 09:27:27 PDT 
(In reply to Stephanie Lewis from comment #4)
> Comment on attachment 382530 [details]
> Patch
> 
> Either I'm blind or you forgot to include the iteration_compatibility file

Definitely forgot to include the iteration_compatibility.py file. Let's try this again...
Comment 7 Jonathan Bedard 2019-11-01 17:08:13 PDT 
Created attachment 382658 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-11-01 18:17:17 PDT 
Comment on attachment 382658 [details]
Patch for landing

Clearing flags on attachment: 382658

Committed r251961: <https://trac.webkit.org/changeset/251961>
Comment 9 WebKit Commit Bot 2019-11-01 18:17:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-11-01 18:18:15 PDT 
<rdar://problem/56834640>