Bug 221043 – [Flatpak SDK] Get rid of Python2

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Philippe Normand]

https://bugs.webkit.org/show_bug.cgi?id=221029#c4

[Michael Catanzaro]

This probably depends on bug #203701, if that's still an issue. Should probably not be hard, though....

[Philippe Normand]

Created attachment 418554 [details]
Patch

[Philippe Normand]

With this WIP patch some tests are now timing-out. Investigation pending. Reproducer:

WEBKIT_FLATPAK_USER_DIR=$PWD/WebKitBuild/UserFlatpak.Local run-webkit-tests  --gtk --no-retry-failures --no-show-results --verbose --details --debug-rwt-logging media/muted-video-is-playing-audio.html

[Jonathan Bedard]

Apple doesn't use Flatpak, so this doesn't effect the configurations I work with, but it's worth noting that run-webkit-tests still has an issue with multiprocessing that prevents it from running with Python 3.8. It's on my list of things to work on in the near future, but this is what is preventing Apple's infrastructure from dropping Python 2 support, not sure how relevant that is here.

[Philippe Normand]

Thanks Jonathan! This might be relevant indeed because our SDK ships Python 3.8. Do you know if 3.9 is supposed to work with the existing r-w-t? In which case we could update to that version in our SDK.

[Jonathan Bedard]

(In reply to Philippe Normand from comment #5)
> Thanks Jonathan! This might be relevant indeed because our SDK ships Python
> 3.8. Do you know if 3.9 is supposed to work with the existing r-w-t? In
> which case we could update to that version in our SDK.

Have not tested, but it's definitely going to have the same problem. The issue is that newer versions of Python aren't using fork(), so everything needs to be pickle-able to be passed to child processes.

[Philippe Normand]

I checked this recently, the layout tests run fine on Python3, excepted the http ones which require the python2 websocket server.

[Carlos Alberto Lopez Perez]

(In reply to Philippe Normand from comment #7)
> I checked this recently, the layout tests run fine on Python3, excepted the
> http ones which require the python2 websocket server.

See also bug 226658

[Philippe Normand]

Created attachment 454555 [details]
[fast-cq] Patch

[EWS]

Committed r291219 (248374@main): <https://commits.webkit.org/248374@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454555 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90236251>