Bug 221029 – REGRESSION(r271634): keyring still failing to retrieve secrets

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Philippe Normand]

Bug 220736 is still happening. Downgrading keyring to 7.3.1 makes it work again. This module is now optional in the github scm module, I'm not sure why the version was bumped in the first place, anyway.

[Philippe Normand]

Created attachment 418516 [details]
Patch

[Michael Catanzaro]

Comment on attachment 418516 [details]
Patch

I agree this is the version of the patch that should land.

But could you please also test if the newest version, 22.0.1, works? We can't actually upgrade to that now, because it doesn't support python2, but if it doesn't work then we need to investigate further and figure out what has gone wrong.

P.S. The keyring package was upgraded for no reason, see https://bugs.webkit.org/show_bug.cgi?id=220736#c12. So downgrading should be fine. But it will be upgraded again eventually....

[Philippe Normand]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 418516 [details]
> Patch
> 
> I agree this is the version of the patch that should land.
> 
> But could you please also test if the newest version, 22.0.1, works? We
> can't actually upgrade to that now, because it doesn't support python2, but
> if it doesn't work then we need to investigate further and figure out what
> has gone wrong.
> 

This could be done as part of the migration of webkitpy to python3. IDK if there's a tracking bug for that though.

> P.S. The keyring package was upgraded for no reason, see
> https://bugs.webkit.org/show_bug.cgi?id=220736#c12. So downgrading should be
> fine. But it will be upgraded again eventually....

Thanks for confirming!

[Michael Catanzaro]

(In reply to Philippe Normand from comment #3)
> This could be done as part of the migration of webkitpy to python3. IDK if
> there's a tracking bug for that though.

webkitpy already fully supports both python2 and python3, and both are tested on the EWS. The tracking bug for that was bug #184986. I was going to say: "If your runtime is based on freedesktop-sdk, it is probably already using python3, because python2 was removed in 19.08 and that was a pretty long time ago." But I see you are manually building python2 on top of freedesktop-sdk 20.08. So... if /usr/bin/python is still pointing to python2, that might indeed explain the behavior difference.

Is there some strong reason that is still needed? It looks like all the python2 elements under Tools/buildstream/elements are only needed by sdk-platform.bst and that suggests they can probably just be dropped... assuming we don't notice any explosions when removed. Nothing in WebKit should still require python2.

[Michael Catanzaro]

(afaik webkitpy maintains python2 support only for Apple internal reasons. All our scripts and dependencies should already be fully-compatible with python3. In theory.)

[Philippe Normand]

I added Python2 in the SDK indeed, and then moved on with other things :) I suppose it could be removed now indeed.

[Michael Catanzaro]

Well maybe not, looks like bug #203701 might need fixed. (I guess it's been a very long time since I last attempted to run layout tests....)

[Philippe Normand]

Committed r271952: <https://trac.webkit.org/changeset/271952>

[Radar WebKit Bug Importer]

<rdar://problem/73661761>