Bug 223888 - [GStreamer] Test harness should use a mock audio output device
Summary: [GStreamer] Test harness should use a mock audio output device
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on: 224053
Blocks:
  Show dependency treegraph
 
Reported: 2021-03-29 11:32 PDT by Philippe Normand
Modified: 2021-04-06 06:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.01 KB, patch)
2021-04-01 09:58 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-03-29 11:32:37 PDT
Since ~ 2012 we have a script called "pulseaudio_sanitizer" which unloads/loads some restore-stream module. This is not working at all with pipewire-pulse. Besides, having to bear with beeps and boops when running tests on a desktop machine is a bit annoying.

Proposal: Use a fakeaudiosink element, up-ranked when running the test harness, so that it is picked up by autoaudiosink.
Comment 1 Philippe Normand 2021-04-01 09:58:49 PDT
Created attachment 424910 [details]
Patch
Comment 2 Adrian Perez 2021-04-01 11:44:41 PDT
Comment on attachment 424910 [details]
Patch

Good one, and nice to see some code go the way of the dodo, too =)
Comment 3 EWS 2021-04-06 06:38:20 PDT
Committed r275513: <https://commits.webkit.org/r275513>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424910 [details].