When discussing <https://bugs.webkit.org/show_bug.cgi?id=192161>, which lays the groundwork for <https://bugs.webkit.org/show_bug.cgi?id=192162>, Lucas Forschler pointed out to me that while devices types are always capitalized, platforms are never capitalized. This will no doubt cause confusion when device types are embedded into expected results. To remedy this confusion, we can make the DeviceType class ignore the case of the contained strings when comparing. This means a DeviceType constructed with a lowercase string would match the DeviceType coming from simctl (which will have some letters capitalized)
<rdar://problem/46491558>
Created attachment 356617 [details] Patch
Comment on attachment 356617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356617&action=review lgtm with typo fix. > Tools/ChangeLog:10 > + against DeviceTypes coming form the simulator runtime. typo: from
Created attachment 356620 [details] Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 356620 [details]: http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html bug 192418 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 356620 [details]: webgl/2.0.0/conformance/more/glsl/arrayOutOfBounds.html bug 192419 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 356620 [details] Patch for landing Clearing flags on attachment: 356620 Committed r238906: <https://trac.webkit.org/changeset/238906>
All reviewed patches have been landed. Closing bug.
Comment on attachment 356620 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=356620&action=review > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:147 > + def test_comparsion_lower_case(self): Typo here: "comparsion"
Reopening to attach new patch.
Created attachment 356748 [details] Patch for landing
(In reply to Darin Adler from comment #9) > Comment on attachment 356620 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356620&action=review > > > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:147 > > + def test_comparsion_lower_case(self): > > Typo here: "comparsion" Oops, thanks Darin, landing a fix for the typo.
The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: inspector/canvas/recording-bitmaprenderer.html bug 192475 (author: drousso@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-hangul.html bug 192476 (author: mjs@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: webgl/1.0.2/conformance/more/conformance/methods.html bug 192477 (author: roger_fong@apple.com) workers/bomb.html bug 192050 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 356748 [details] Patch for landing Clearing flags on attachment: 356748 Committed r238943: <https://trac.webkit.org/changeset/238943>