Bug 192472 - webkitpy: Create device given lower-case DeviceType
Summary: webkitpy: Create device given lower-case DeviceType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-06 12:59 PST by Jonathan Bedard
Modified: 2018-12-06 14:09 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2018-12-06 13:03 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-12-06 12:59:09 PST 
After <https://bugs.webkit.org/show_bug.cgi?id=192409>, we can compare device types regardless of case, but constructing devices still requires an exact match. We should address this.
Comment 1 Radar WebKit Bug Importer 2018-12-06 12:59:33 PST 
<rdar://problem/46532650>
Comment 2 Jonathan Bedard 2018-12-06 13:03:16 PST 
Created attachment 356743 [details]
Patch
Comment 3 WebKit Commit Bot 2018-12-06 14:09:27 PST 
Comment on attachment 356743 [details]
Patch

Clearing flags on attachment: 356743

Committed r238940: <https://trac.webkit.org/changeset/238940>
Comment 4 WebKit Commit Bot 2018-12-06 14:09:28 PST 
All reviewed patches have been landed.  Closing bug.