Bug 191379 – WKWebView doesn’t respond to -copyFont: and -pasteFont:

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

WKWebView doesn’t respond to -copyFont: and -pasteFont:

<rdar://problem/45878659>.

[Devin Rousso]

Created attachment 446245 [details]
Patch

[Devin Rousso]

Created attachment 446257 [details]
Patch

rebase

[Devin Rousso]

Created attachment 446498 [details]
Patch

[Devin Rousso]

Created attachment 446795 [details]
Patch

[Wenson Hsieh]

Comment on attachment 446795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446795&action=review

r=mews

> Source/WebCore/editing/mac/EditorMac.mm:109
> +void Editor::platformCopyFont()

We should file a followup to unify this code with the WebKitLegacy implementation in WebHTMLView.

> Source/WebCore/editing/mac/EditorMac.mm:125
> +void Editor::platformPasteFont()

Same, for this.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4174
> +        // FIXME: Does iOS have a different pasteboard for fonts?

iOS does not support a dedicated font pasteboard, no. Falling back to the general pasteboard is probably okay here (and we can remove the FIXME).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4186
> +        // FIXME: Does iOS have a different pasteboard for fonts?

Ditto.

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1555
> +        // FIXME: Does iOS have a different pasteboard for fonts?

Ditto.

> Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:663
> +        grantAccessToCurrentPasteboardData(NSFontPboard);

Can you use `NSPasteboardNameFont` instead of suppressing deprecation warnings?

[Wenson Hsieh]

Comment on attachment 446795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446795&action=review

> LayoutTests/editing/execCommand/mac/copyFont-pasteFont-expected.html:4
> +#copy {

Nit - indentation is a bit off in a few places in this file.

> LayoutTests/editing/execCommand/mac/copyFont-pasteFont.html:3
> +    <script src=../../editing.js></script>

Ditto, re: indentation.

[Devin Rousso]

Comment on attachment 446795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446795&action=review

>> LayoutTests/editing/execCommand/mac/copyFont-pasteFont-expected.html:4
>> +#copy {
> 
> Nit - indentation is a bit off in a few places in this file.

Oh lol that's just my personal preference.  I find that indenting inline CSS/JS to match the indentation of the surrounding DOM is odd because if you then did `style.textContent` there'd be all this extra indentation for seemingly no reason.

[Devin Rousso]

Created attachment 446837 [details]
Patch

[Devin Rousso]

Created attachment 446842 [details]
Patch

[EWS]

Committed r286894 (245122@main): <https://commits.webkit.org/245122@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446842 [details].