Bug 233938 - Add helper methods to `WebCore::FontShadow` for serializing to CSS and converting to `NSShadow`
Summary: Add helper methods to `WebCore::FontShadow` for serializing to CSS and conver...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 191379
  Show dependency tree / graph
 
Reported: 2021-12-07 10:57 PST by Devin Rousso
Modified: 2021-12-07 16:42 PST (History)
8 users (show)

See Also:

Attachments
Patch (17.72 KB, patch)
2021-12-07 11:27 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (18.12 KB, patch)
2021-12-07 12:03 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-12-07 10:57:30 PST 
.
Comment 1 Devin Rousso 2021-12-07 11:27:26 PST 
Created attachment 446208 [details]
Patch
Comment 2 Tim Horton 2021-12-07 11:35:09 PST 
Comment on attachment 446208 [details]
Patch

This adds dead code so needs way more words about motivation.
Comment 3 Devin Rousso 2021-12-07 11:56:09 PST 
this will be used in <https://webkit.org/b/191379> (hence why this bug blocks that)

i'll explain in the ChangeLog
Comment 4 Devin Rousso 2021-12-07 12:03:19 PST 
Created attachment 446218 [details]
Patch
Comment 5 EWS 2021-12-07 16:41:34 PST 
Committed r286630 (244943@main): <https://commits.webkit.org/244943@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446218 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-07 16:42:21 PST 
<rdar://problem/86182891>