Bug 234065 - Add a way to write a `SharedBuffer` to the Pasteboard
Summary: Add a way to write a `SharedBuffer` to the Pasteboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 191379
  Show dependency treegraph
 
Reported: 2021-12-08 19:38 PST by Devin Rousso
Modified: 2021-12-10 11:05 PST (History)
6 users (show)

See Also:


Attachments
Patch (28.89 KB, patch)
2021-12-08 19:52 PST, Devin Rousso
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (28.91 KB, patch)
2021-12-08 20:45 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (7.32 KB, patch)
2021-12-09 16:10 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-12-08 19:38:43 PST
.
Comment 1 Devin Rousso 2021-12-08 19:52:09 PST
Created attachment 446490 [details]
Patch
Comment 2 Devin Rousso 2021-12-08 20:45:44 PST
Created attachment 446496 [details]
Patch
Comment 3 Wenson Hsieh 2021-12-08 22:13:18 PST
Comment on attachment 446496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446496&action=review

> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:553
> +#if !PLATFORM(MACCATALYST)
> +    [representationsToRegister addData:[webIOSPastePboardType dataUsingEncoding:NSUTF8StringEncoding] forType:webIOSPastePboardType];
> +#endif

I'm not sure why we need to preserve this bit of "history" in modern code.

That said, this iOS-specific code is not going to be exercised by anything, right? If that's the case, should we just leave it as a method stub?
Comment 4 Devin Rousso 2021-12-09 16:10:04 PST
Created attachment 446626 [details]
Patch
Comment 5 EWS 2021-12-10 11:04:12 PST
Committed r286861 (245094@main): <https://commits.webkit.org/245094@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446626 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-10 11:05:19 PST
<rdar://problem/86330756>