Bug 233939 – Add a `DOMPasteAccessCategory` to control which pasteboard the WebProcess is granted access to when pasting

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Devin Rousso]

.

[Devin Rousso]

Created attachment 446217 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Wenson Hsieh]

Comment on attachment 446217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446217&action=review

> Source/WebCore/page/Frame.h:179
> +    bool requestDOMPasteAccess(DOMPasteAccessCategory);

Could we make this default to `DOMPasteAccessCategory::General`?

[Devin Rousso]

Comment on attachment 446217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446217&action=review

>> Source/WebCore/page/Frame.h:179
>> +    bool requestDOMPasteAccess(DOMPasteAccessCategory);
> 
> Could we make this default to `DOMPasteAccessCategory::General`?

Sure.  I kinda like the explicit-ness of having the callsite know exactly which category they're asking for, but I can also see the benefit in having `General` be the default.

[Devin Rousso]

Created attachment 446222 [details]
Patch

[EWS]

Committed r286632 (244945@main): <https://commits.webkit.org/244945@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446222 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86183512>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/286632/webkit

broke 3 pasteboard tests on iOS 15 

editing/pasteboard/dom-paste/dom-paste-confirmation.html
editing/pasteboard/dom-paste/dom-paste-consecutive-confirmations.html
editing/pasteboard/dom-paste/dom-paste-requires-user-gesture.html

tracking in https://bugs.webkit.org/show_bug.cgi?id=234014

[Truitt Savell]

Reverted r286632 for reason:

Broke 3 tests on iOS

Committed r286705 (244984@trunk): <https://commits.webkit.org/244984@trunk>

[Devin Rousso]

Created attachment 446487 [details]
Patch

fix mistake in `-[WKContentView pasteForWebView:]`

[EWS]

Committed r286825 (245059@main): <https://commits.webkit.org/245059@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446487 [details].