RESOLVED MOVED 189955
[WHLSL] Implement Metal code generation for semantics and buffers
https://bugs.webkit.org/show_bug.cgi?id=189955
Summary [WHLSL] Implement Metal code generation for semantics and buffers
Thomas Denney
Reported 2018-09-25 11:09:22 PDT
There is no support for the new semantic syntax introduced in https://bugs.webkit.org/show_bug.cgi?id=189134.
Attachments
WIP (516.90 KB, patch)
2018-09-28 16:47 PDT, Thomas Denney
no flags
Thomas Denney
Comment 1 2018-09-25 11:33:52 PDT
As part of the support for this, I’m going to rewrite the way that code generation for entry points works, so that the following is now true: * All stage_in parameters are collected into a single struct type with appropriate attributes set based on semantics (e.g. position, other offsets) * All other parameters (buffers, textures, etc) are separated out with appropriate offsets/attributes determined based on the semantics in the original WHLSL * Entry points in WHLSL are just compiled as regular Metal functions, as they were before, except that now an additional wrapper method unpacks the new parameters and repacks them in the style expected by WHLSL, and the same is true on the return.
Thomas Denney
Comment 2 2018-09-28 16:47:01 PDT
Myles C. Maxfield
Comment 3 2018-10-13 14:23:08 PDT
Myles C. Maxfield
Comment 4 2018-10-13 14:51:58 PDT
Note You need to log in before you can comment on or make changes to this bug.