Bug 189936 - [WHLSL] Metal codegen needs to correctly handle all entry point arguments
Summary: [WHLSL] Metal codegen needs to correctly handle all entry point arguments
Status: RESOLVED MOVED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thomas Denney
URL:
Keywords:
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2018-09-24 16:47 PDT by Thomas Denney
Modified: 2018-10-13 14:52 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Denney 2018-09-24 16:47:46 PDT 
WHLSL and MSL shader parameter/return types may differ in their layout — the stage_in parameters need to be flattened into a single struct for example — so shader entry points should unpack their parameters into the expected layout and when they exit they should repack into this format.
Comment 1 Myles C. Maxfield 2018-09-24 19:00:41 PDT 
It might be easier to implement the packing/unpacking if we make a new function that represents the entry point that just does the packing/unpacking, the global struct, and the trap statement bool
Comment 2 Myles C. Maxfield 2018-10-13 14:23:10 PDT 
Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/26
Comment 3 Myles C. Maxfield 2018-10-13 14:52:17 PDT 
https://github.com/gpuweb/WHLSL/issues/26