Bug 189134 - [WHSL] Implement semantics
Summary: [WHSL] Implement semantics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 189033 189387 (view as bug list)
Depends on:
Blocks: 176199 189202
  Show dependency treegraph
 
Reported: 2018-08-29 17:45 PDT by Myles C. Maxfield
Modified: 2018-10-13 14:44 PDT (History)
6 users (show)

See Also:


Attachments
WIP (81.82 KB, patch)
2018-09-21 21:33 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (81.82 KB, patch)
2018-09-21 21:35 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (100.06 KB, patch)
2018-09-22 01:43 PDT, Myles C. Maxfield
fpizlo: review+
Details | Formatted Diff | Diff
Patch for committing (99.84 KB, patch)
2018-09-24 23:48 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch for committing (102.55 KB, patch)
2018-09-25 13:43 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch for committing (104.57 KB, patch)
2018-09-25 13:55 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-29 17:45:38 PDT
Implement semantics
Comment 1 Radar WebKit Bug Importer 2018-09-12 18:50:31 PDT
<rdar://problem/44402998>
Comment 2 Myles C. Maxfield 2018-09-21 21:33:46 PDT
Created attachment 350491 [details]
WIP
Comment 3 Myles C. Maxfield 2018-09-21 21:35:17 PDT
Created attachment 350493 [details]
WIP
Comment 4 Myles C. Maxfield 2018-09-22 01:27:45 PDT
*** Bug 189033 has been marked as a duplicate of this bug. ***
Comment 5 Myles C. Maxfield 2018-09-22 01:43:05 PDT
Created attachment 350505 [details]
Patch
Comment 6 Myles C. Maxfield 2018-09-22 02:47:00 PDT
*** Bug 189387 has been marked as a duplicate of this bug. ***
Comment 7 Myles C. Maxfield 2018-09-22 14:30:25 PDT
Comment on attachment 350505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350505&action=review

> Tools/WebGPUShadingLanguageRI/Parse.js:1230
> +            return fail("Semantic  is not 32-bit unsigned integer: " + index.text);

Double space
Comment 8 Filip Pizlo 2018-09-24 15:41:31 PDT
Comment on attachment 350505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350505&action=review

> Tools/WebGPUShadingLanguageRI/Field.js:2
> - * Copyright (C) 2017 Apple Inc. All rights reserved.
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2017-2018

> Tools/WebGPUShadingLanguageRI/FuncParameter.js:2
> - * Copyright (C) 2017 Apple Inc. All rights reserved.
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2017-2018
Comment 9 Myles C. Maxfield 2018-09-24 23:48:57 PDT
Created attachment 350740 [details]
Patch for committing
Comment 10 Myles C. Maxfield 2018-09-25 13:43:12 PDT
Created attachment 350782 [details]
Patch for committing
Comment 11 Myles C. Maxfield 2018-09-25 13:55:13 PDT
Created attachment 350788 [details]
Patch for committing
Comment 12 Myles C. Maxfield 2018-09-25 14:21:49 PDT
Committed r236475: <https://trac.webkit.org/changeset/236475>
Comment 13 Myles C. Maxfield 2018-10-13 14:44:16 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/52