Bug 189210 - [WHLSL] Allow uniform buffers to be used in the interpreter
Summary: [WHLSL] Allow uniform buffers to be used in the interpreter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 177093 (view as bug list)
Depends on: 189986
Blocks: 176199 189202
  Show dependency tree / graph
 
Reported: 2018-08-31 14:20 PDT by Myles C. Maxfield
Modified: 2018-10-13 15:02 PDT (History)
7 users (show)

See Also:

Attachments
Buffers already work (6.50 KB, patch)
2018-09-24 02:16 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (16.10 KB, patch)
2018-09-24 20:23 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (13.74 KB, patch)
2018-09-25 15:00 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Depends on pointer equality (165.63 KB, patch)
2018-09-25 22:37 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-31 14:20:18 PDT 
...
Comment 1 Radar WebKit Bug Importer 2018-09-12 18:50:25 PDT 
<rdar://problem/44402996>
Comment 2 Myles C. Maxfield 2018-09-22 04:03:15 PDT 
We also have to figure out how to do things like

device atomic_uint[] x : register(u0);
InterlockedAdd(&x[0], 1, null);
Comment 3 Myles C. Maxfield 2018-09-22 16:52:12 PDT 
*** Bug 177093 has been marked as a duplicate of this bug. ***
Comment 4 Myles C. Maxfield 2018-09-24 02:16:20 PDT 
Created attachment 350627 [details]
Buffers already work
Comment 5 Myles C. Maxfield 2018-09-24 02:17:43 PDT 
The only things remaining are just to make sure you can't write to the constant address space, and make sure pointers the standard library functions work with all the appropriate address spaces.
Comment 6 Myles C. Maxfield 2018-09-24 02:18:15 PDT 
Comment on attachment 350627 [details]
Buffers already work

View in context: https://bugs.webkit.org/attachment.cgi?id=350627&action=review

> Tools/WebGPUShadingLanguageRI/Test.js:809
> +tests.threadArrayLoad = function()

Poorly named
Comment 7 Myles C. Maxfield 2018-09-24 20:23:42 PDT 
Created attachment 350731 [details]
WIP
Comment 8 Myles C. Maxfield 2018-09-25 15:00:22 PDT 
Created attachment 350796 [details]
Patch
Comment 9 Myles C. Maxfield 2018-09-25 22:37:48 PDT 
Created attachment 350849 [details]
Depends on pointer equality
Comment 10 WebKit Commit Bot 2018-09-28 19:28:05 PDT 
Comment on attachment 350849 [details]
Depends on pointer equality

Clearing flags on attachment: 350849

Committed r236635: <https://trac.webkit.org/changeset/236635>
Comment 11 WebKit Commit Bot 2018-09-28 19:28:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Myles C. Maxfield 2018-09-28 23:55:17 PDT 
Committed r236639: <https://trac.webkit.org/changeset/236639>
Comment 13 Myles C. Maxfield 2018-10-13 15:02:27 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/46