Bug 177093 - WSL should flag stores to constant references
Summary: WSL should flag stores to constant references
Status: RESOLVED DUPLICATE of bug 189210
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 177303
Blocks: 176199 189202
  Show dependency tree / graph
 
Reported: 2017-09-18 12:00 PDT by Filip Pizlo
Modified: 2018-10-13 19:46 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-18 12:00:19 PDT 
Patch forthcoming.
Comment 1 Radar WebKit Bug Importer 2018-09-12 18:52:17 PDT 
<rdar://problem/44403033>
Comment 2 Myles C. Maxfield 2018-09-22 04:16:06 PDT 
This requires that address spaces get propagated to individual values.

constant float[] a : register(b0)
a[3] = 7;

We need to realize that the type of a[3] is "constant float"

This analysis is required for things like

device atomic_uint[] x : register(u0);
InterlockedAdd(&x[0], 1, null);

Here, we have to realize that the type of &x[0] is type "device uint*"
Comment 3 Myles C. Maxfield 2018-09-22 16:52:12 PDT 

*** This bug has been marked as a duplicate of bug 189210 ***
Comment 4 Myles C. Maxfield 2018-10-13 19:46:00 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/190