Bug 189986 - [WHLSL] Pointers should have automatically-generated equality checks
Summary: [WHLSL] Pointers should have automatically-generated equality checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 189202 189210
  Show dependency tree / graph
 
Reported: 2018-09-25 21:39 PDT by Myles C. Maxfield
Modified: 2018-10-13 14:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (83.67 KB, patch)
2018-09-25 21:46 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (89.38 KB, patch)
2018-09-25 22:11 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-09-25 21:39:51 PDT 
[WHLSL] Pointers should have automatically-generated equality checks
Comment 1 Myles C. Maxfield 2018-09-25 21:46:08 PDT 
Created attachment 350845 [details]
Patch
Comment 2 EWS Watchlist 2018-09-25 21:48:31 PDT 
Attachment 350845 [details] did not pass style-queue:


ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:787:  developmentRegion is not English.  [xcodeproj/settings] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Myles C. Maxfield 2018-09-25 22:11:33 PDT 
Created attachment 350847 [details]
Patch
Comment 4 EWS Watchlist 2018-09-25 22:14:29 PDT 
Attachment 350847 [details] did not pass style-queue:


ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:787:  developmentRegion is not English.  [xcodeproj/settings] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2018-09-28 17:48:41 PDT 
Comment on attachment 350847 [details]
Patch

Clearing flags on attachment: 350847

Committed r236628: <https://trac.webkit.org/changeset/236628>
Comment 6 WebKit Commit Bot 2018-09-28 17:48:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-28 17:49:21 PDT 
<rdar://problem/44880171>
Comment 8 Myles C. Maxfield 2018-10-13 14:23:03 PDT 
Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/22
Comment 9 Myles C. Maxfield 2018-10-13 14:51:18 PDT 
https://github.com/gpuweb/WHLSL/issues/22