WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174879
Part 1 of: Rename DatabaseProcess to StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=174879
Summary
Part 1 of: Rename DatabaseProcess to StorageProcess
Brady Eidson
Reported
2017-07-26 17:01:41 PDT
Part 1 of: Rename DatabaseProcess to StorageProcess This will start with renaming all of the relevant files on disk and then making the minimal set of code changes to keep things building. Part 2 will go through all of WebKit and rename all the other things that are now obsolete.
Attachments
WIP patch
(133.59 KB, patch)
2017-07-26 17:04 PDT
,
Brady Eidson
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
(1.13 MB, application/zip)
2017-07-26 18:03 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews124 for ios-simulator-wk2
(941.96 KB, application/zip)
2017-07-26 18:05 PDT
,
Build Bot
no flags
Details
Next WIP
(133.70 KB, patch)
2017-07-26 19:36 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New WIP
(134.67 KB, patch)
2017-07-26 20:02 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New WIP
(134.75 KB, patch)
2017-07-26 20:09 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New WIP
(134.85 KB, patch)
2017-07-26 20:15 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New WIP
(135.20 KB, patch)
2017-07-26 20:23 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New WIP
(136.09 KB, patch)
2017-07-26 20:40 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New WIP
(153.36 KB, patch)
2017-07-26 21:43 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New WIP
(153.96 KB, patch)
2017-07-26 21:58 PDT
,
Brady Eidson
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
(1.06 MB, application/zip)
2017-07-26 22:57 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews124 for ios-simulator-wk2
(760.31 KB, application/zip)
2017-07-26 23:28 PDT
,
Build Bot
no flags
Details
New WIP
(168.97 KB, patch)
2017-07-27 11:53 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
With a ChangeLog, for review
(176.10 KB, patch)
2017-07-27 12:41 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Patch
(337.34 KB, patch)
2017-07-27 13:22 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Patch for landing
(176.12 KB, patch)
2017-07-27 13:23 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2
(13.30 MB, application/zip)
2017-07-27 14:51 PDT
,
Build Bot
no flags
Details
Patch for EWS
(149.08 KB, patch)
2017-07-31 13:19 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
New for EWS
(148.73 KB, patch)
2017-07-31 13:50 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
More EWS
(144.83 KB, patch)
2017-07-31 14:06 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
More EWS
(144.27 KB, patch)
2017-07-31 14:07 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
More EWS
(139.58 KB, patch)
2017-07-31 15:02 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
More EWS
(140.53 KB, patch)
2017-07-31 16:37 PDT
,
Brady Eidson
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-elcapitan
(244.89 KB, application/zip)
2017-07-31 17:21 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
(260.49 KB, application/zip)
2017-07-31 17:25 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews114 for mac-elcapitan
(178.51 KB, application/zip)
2017-07-31 17:25 PDT
,
Build Bot
no flags
Details
Landing run
(145.30 KB, patch)
2017-07-31 19:22 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Landing run
(145.30 KB, patch)
2017-07-31 20:36 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(28)
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2017-07-26 17:02:37 PDT
Part 2 -
https://bugs.webkit.org/show_bug.cgi?id=174880
Brady Eidson
Comment 2
2017-07-26 17:04:53 PDT
Comment hidden (obsolete)
Created
attachment 316498
[details]
WIP patch Early patch. This builds on my Mac. Not even bothering with a ChangeLog yet.
Build Bot
Comment 3
2017-07-26 17:08:23 PDT
Comment hidden (obsolete)
Attachment 316498
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4
2017-07-26 18:02:59 PDT
Comment hidden (obsolete)
Comment on
attachment 316498
[details]
WIP patch
Attachment 316498
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/4193294
Number of test failures exceeded the failure limit.
Build Bot
Comment 5
2017-07-26 18:03:01 PDT
Comment hidden (obsolete)
Created
attachment 316501
[details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 6
2017-07-26 18:05:01 PDT
Comment hidden (obsolete)
Comment on
attachment 316498
[details]
WIP patch
Attachment 316498
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/4193248
Number of test failures exceeded the failure limit.
Build Bot
Comment 7
2017-07-26 18:05:02 PDT
Comment hidden (obsolete)
Created
attachment 316502
[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Brady Eidson
Comment 8
2017-07-26 19:36:31 PDT
Comment hidden (obsolete)
Created
attachment 316506
[details]
Next WIP
Build Bot
Comment 9
2017-07-26 19:38:40 PDT
Comment hidden (obsolete)
Attachment 316506
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 10
2017-07-26 20:02:08 PDT
Comment hidden (obsolete)
Created
attachment 316508
[details]
New WIP
Build Bot
Comment 11
2017-07-26 20:05:33 PDT
Comment hidden (obsolete)
Attachment 316508
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 12
2017-07-26 20:09:07 PDT
Comment hidden (obsolete)
Created
attachment 316509
[details]
New WIP
Build Bot
Comment 13
2017-07-26 20:11:43 PDT
Comment hidden (obsolete)
Attachment 316509
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 14
2017-07-26 20:15:36 PDT
Comment hidden (obsolete)
Created
attachment 316510
[details]
New WIP
Build Bot
Comment 15
2017-07-26 20:19:19 PDT
Comment hidden (obsolete)
Attachment 316510
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 16
2017-07-26 20:23:12 PDT
Comment hidden (obsolete)
Created
attachment 316511
[details]
New WIP
Build Bot
Comment 17
2017-07-26 20:25:05 PDT
Comment hidden (obsolete)
Attachment 316511
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 18
2017-07-26 20:40:29 PDT
Comment hidden (obsolete)
Created
attachment 316512
[details]
New WIP
Build Bot
Comment 19
2017-07-26 20:51:38 PDT
Comment hidden (obsolete)
Attachment 316512
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 20
2017-07-26 21:43:15 PDT
Comment hidden (obsolete)
Created
attachment 316519
[details]
New WIP
Build Bot
Comment 21
2017-07-26 21:49:51 PDT
Comment hidden (obsolete)
Attachment 316519
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 14 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 22
2017-07-26 21:58:59 PDT
Created
attachment 316521
[details]
New WIP
Brady Eidson
Comment 23
2017-07-26 22:06:51 PDT
Holy hell, unices building.
Build Bot
Comment 24
2017-07-26 22:57:00 PDT
Comment hidden (obsolete)
Comment on
attachment 316521
[details]
New WIP
Attachment 316521
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/4194627
Number of test failures exceeded the failure limit.
Build Bot
Comment 25
2017-07-26 22:57:01 PDT
Comment hidden (obsolete)
Created
attachment 316523
[details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 26
2017-07-26 23:28:01 PDT
Comment hidden (obsolete)
Comment on
attachment 316521
[details]
New WIP
Attachment 316521
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/4194661
Number of test failures exceeded the failure limit.
Build Bot
Comment 27
2017-07-26 23:28:02 PDT
Comment hidden (obsolete)
Created
attachment 316528
[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Build Bot
Comment 28
2017-07-27 00:04:06 PDT
Comment hidden (obsolete)
Attachment 316521
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 14 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 29
2017-07-27 11:53:07 PDT
Created
attachment 316561
[details]
New WIP Local Mac build works, and layout tests work. crossing fingers for EWS
Build Bot
Comment 30
2017-07-27 11:55:46 PDT
Attachment 316561
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 14 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 31
2017-07-27 12:41:13 PDT
Created
attachment 316564
[details]
With a ChangeLog, for review
Build Bot
Comment 32
2017-07-27 12:44:58 PDT
Attachment 316564
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 14 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 33
2017-07-27 13:18:24 PDT
Comment on
attachment 316564
[details]
With a ChangeLog, for review View in context:
https://bugs.webkit.org/attachment.cgi?id=316564&action=review
> Source/WebKit/CMakeLists.txt:277 > + StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp
Should there be a blank line after this?
Brady Eidson
Comment 34
2017-07-27 13:20:39 PDT
(In reply to Andy Estes from
comment #33
)
> Comment on
attachment 316564
[details]
> With a ChangeLog, for review > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=316564&action=review
> > > Source/WebKit/CMakeLists.txt:277 > > + StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp > > Should there be a blank line after this?
Yup
Brady Eidson
Comment 35
2017-07-27 13:22:43 PDT
Created
attachment 316566
[details]
Patch
Brady Eidson
Comment 36
2017-07-27 13:23:31 PDT
Created
attachment 316567
[details]
Patch for landing
Build Bot
Comment 37
2017-07-27 13:26:27 PDT
Attachment 316567
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 14 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 38
2017-07-27 14:51:31 PDT
Comment on
attachment 316567
[details]
Patch for landing
Attachment 316567
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/4198305
New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Build Bot
Comment 39
2017-07-27 14:51:33 PDT
Created
attachment 316573
[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Brady Eidson
Comment 40
2017-07-27 15:38:19 PDT
(In reply to Build Bot from
comment #39
)
> Created
attachment 316573
[details]
> Archive of layout-test-results from ews125 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Not due to this patch.
WebKit Commit Bot
Comment 41
2017-07-27 16:08:38 PDT
Comment on
attachment 316567
[details]
Patch for landing Clearing flags on attachment: 316567 Committed
r219986
: <
http://trac.webkit.org/changeset/219986
>
WebKit Commit Bot
Comment 42
2017-07-27 16:08:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 43
2017-07-28 16:40:31 PDT
<
rdar://problem/33601748
>
WebKit Commit Bot
Comment 44
2017-07-28 17:53:43 PDT
Re-opened since this is blocked by
bug 174962
Brady Eidson
Comment 45
2017-07-31 13:19:54 PDT
Created
attachment 316797
[details]
Patch for EWS New series of patches - all the file renames and code changes, *except* not actually renaming the XPC service. We'll do that conditionally in a followup.
Build Bot
Comment 46
2017-07-31 13:28:56 PDT
Comment hidden (obsolete)
Attachment 316797
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 14 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 47
2017-07-31 13:50:08 PDT
Comment hidden (obsolete)
Created
attachment 316799
[details]
New for EWS
Build Bot
Comment 48
2017-07-31 13:56:45 PDT
Comment hidden (obsolete)
Attachment 316799
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:161: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 14 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 49
2017-07-31 14:06:45 PDT
Comment hidden (obsolete)
Created
attachment 316801
[details]
More EWS
Brady Eidson
Comment 50
2017-07-31 14:07:49 PDT
Comment hidden (obsolete)
Created
attachment 316802
[details]
More EWS
Build Bot
Comment 51
2017-07-31 14:14:23 PDT
Comment hidden (obsolete)
Attachment 316802
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 52
2017-07-31 15:02:13 PDT
Comment hidden (obsolete)
Created
attachment 316806
[details]
More EWS
Build Bot
Comment 53
2017-07-31 15:06:21 PDT
Comment hidden (obsolete)
Attachment 316806
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 54
2017-07-31 16:37:34 PDT
Comment hidden (obsolete)
Created
attachment 316812
[details]
More EWS
Build Bot
Comment 55
2017-07-31 16:41:10 PDT
Comment hidden (obsolete)
Attachment 316812
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 56
2017-07-31 17:21:50 PDT
Comment hidden (obsolete)
Comment on
attachment 316812
[details]
More EWS
Attachment 316812
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/4231574
Number of test failures exceeded the failure limit.
Build Bot
Comment 57
2017-07-31 17:21:52 PDT
Comment hidden (obsolete)
Created
attachment 316818
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 58
2017-07-31 17:25:06 PDT
Comment hidden (obsolete)
Comment on
attachment 316812
[details]
More EWS
Attachment 316812
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/4231576
Number of test failures exceeded the failure limit.
Build Bot
Comment 59
2017-07-31 17:25:07 PDT
Comment hidden (obsolete)
Created
attachment 316819
[details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 60
2017-07-31 17:25:54 PDT
Comment hidden (obsolete)
Comment on
attachment 316812
[details]
More EWS
Attachment 316812
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/4231560
Number of test failures exceeded the failure limit.
Build Bot
Comment 61
2017-07-31 17:25:56 PDT
Comment hidden (obsolete)
Created
attachment 316821
[details]
Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Brady Eidson
Comment 62
2017-07-31 19:13:33 PDT
Comment hidden (obsolete)
lol, left in some debugging code from a different bug exploration. Let's try this again.
Brady Eidson
Comment 63
2017-07-31 19:22:43 PDT
Comment hidden (obsolete)
Created
attachment 316826
[details]
Landing run
Brady Eidson
Comment 64
2017-07-31 20:36:05 PDT
Created
attachment 316829
[details]
Landing run
Build Bot
Comment 65
2017-07-31 22:08:56 PDT
Comment hidden (obsolete)
Attachment 316829
[details]
did not pass style-queue: ERROR: Source/WebKit/StorageProcess/ios/StorageProcessIOS.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.h:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/StorageProcess.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:30: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/PlatformWPE.cmake:264: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "StorageProcess/gtk/StorageProcessMainGtk.cpp". [list/emptyline] [5] Total errors found: 13 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 66
2017-08-01 07:19:35 PDT
Comment on
attachment 316829
[details]
Landing run Clearing flags on attachment: 316829 Committed
r220094
: <
http://trac.webkit.org/changeset/220094
>
WebKit Commit Bot
Comment 67
2017-08-01 07:19:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug