Bug 175034 – Part 3 of: Rename DatabaseProcess to StorageProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Part 3 of: Rename DatabaseProcess to StorageProcess

This tracks actual renaming of the XPC service (which we'll do just for Mac and the iOS simulator for now)

[Radar WebKit Bug Importer]

<rdar://problem/33657240>

[Andy Estes]

Created attachment 316891 [details]
Patch

Comment on attachment 316891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316891&action=review

> Source/WebKit/ChangeLog:10
> +        * Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
> +        com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
> +        and iOS Simulator.

Why the different names?

[Andy Estes]

(In reply to mitz from comment #3)
> Comment on attachment 316891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316891&action=review
> 
> > Source/WebKit/ChangeLog:10
> > +        * Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
> > +        com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
> > +        and iOS Simulator.
> 
> Why the different names?

So that tip-of-tree WebKit can continue to work on devices running iOS 11 without having to remove the XPC cache.

[Ryosuke Niwa]

(In reply to mitz from comment #3)
> Comment on attachment 316891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316891&action=review
> 
> > Source/WebKit/ChangeLog:10
> > +        * Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
> > +        com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
> > +        and iOS Simulator.
> 
> Why the different names?

Due to an Apple internal build system requirement. I've forwarded you relevant emails.

(In reply to Andy Estes from comment #4)
> (In reply to mitz from comment #3)
> > Comment on attachment 316891 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=316891&action=review
> > 
> > > Source/WebKit/ChangeLog:10
> > > +        * Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
> > > +        com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
> > > +        and iOS Simulator.
> > 
> > Why the different names?
> 
> So that tip-of-tree WebKit can continue to work on devices running iOS 11
> without having to remove the XPC cache.

Removing the cache isn’t necessary. The cache is ignored for frameworks listed under the UncachedServices key of com.apple.xpc.launchd.bootstrap.plist. Even if it were required for some reason, it ought to be limited to iOS 11 and explained in the change log.

[Andy Estes]

Created attachment 316892 [details]
Patch

[Andy Estes]

(In reply to mitz from comment #6)
> it ought to be limited to iOS 11 and explained in the change log.

Limiting this to iOS 11 is the plan, although I need to install a new SDK to test that plan. For now we decided to start with Mac and iOS Simulator.

[Brady Eidson]

(In reply to mitz from comment #6)
> (In reply to Andy Estes from comment #4)
> > (In reply to mitz from comment #3)
> > > Comment on attachment 316891 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=316891&action=review
> > > 
> > > > Source/WebKit/ChangeLog:10
> > > > +        * Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
> > > > +        com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
> > > > +        and iOS Simulator.
> > > 
> > > Why the different names?
> > 
> > So that tip-of-tree WebKit can continue to work on devices running iOS 11
> > without having to remove the XPC cache.
> 
> Removing the cache isn’t necessary. The cache is ignored for frameworks
> listed under the UncachedServices key of
> com.apple.xpc.launchd.bootstrap.plist. Even if it were required for some
> reason, it ought to be limited to iOS 11 and explained in the change log.

I don't actually think this is right. I thought I replied to a message from you on the email thread, I'll go double check that now...

[WebKit Commit Bot]

Comment on attachment 316892 [details]
Patch

Rejecting attachment 316892 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 316892, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
eeded at 9732 (offset 49 lines).
Hunk #6 succeeded at 9740 (offset 49 lines).
1 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/WebKit.xcodeproj/project.pbxproj.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebKitTestRunner/TestController.cpp
Hunk #1 succeeded at 890 (offset 3 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brady Eidson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4284741

[Andy Estes]

Created attachment 317725 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 317725 [details]
Patch

Clearing flags on attachment: 317725

Committed r220501: <http://trac.webkit.org/changeset/220501>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.