The spec says that we're supposed to use xx-small for font size 1. Current spec: https://www.w3.org/TR/CSS2/fonts.html#propdef-font-size Draft spec: https://drafts.csswg.org/css-fonts-3/#font-size-prop
Created attachment 311974 [details] Patch
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3873494 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Created attachment 311976 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3873499 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Created attachment 311978 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3873509 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Created attachment 311979 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3873526 New failing tests: tables/mozilla/bugs/bug57828-2.html tables/mozilla/bugs/bug113424.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug647.html fast/text/basic/011.html fast/forms/form-element-geometry.html tables/mozilla/other/slashlogo.html tables/mozilla/bugs/bug16012.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/core/bloomberg.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html editing/execCommand/query-font-size.html tables/mozilla/bugs/bug4093.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug22513.html tables/mozilla/other/ms.html
Created attachment 311980 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Created attachment 311982 [details] Patch
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3874316 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Created attachment 311985 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3874374 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Created attachment 311986 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3874364 New failing tests: tables/mozilla/bugs/bug57828-2.html tables/mozilla/bugs/bug113424.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug647.html fast/text/basic/011.html fast/forms/form-element-geometry.html tables/mozilla/other/slashlogo.html tables/mozilla/bugs/bug16012.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/core/bloomberg.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html editing/execCommand/query-font-size.html tables/mozilla/bugs/bug4093.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug22513.html tables/mozilla/other/ms.html
Created attachment 311988 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3874340 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Created attachment 311989 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 311982 [details] Patch Hi, thanks for this patch. It looks like you'll need to rebaseline the failing tests if you want to fix this bug.
(In reply to Michael Catanzaro from comment #19) > Comment on attachment 311982 [details] > Patch > > Hi, thanks for this patch. It looks like you'll need to rebaseline the > failing tests if you want to fix this bug. When i run the tests that did fail for eg: Tools/Scripts/run-webkit-tests editing/execCommand/query-font-size.html I get the following result witch seem to be succeed, but when i upload the patch the tests fail Using port 'mac-sierra-wk2' Test configuration: <sierra, x86_64, release> Placing test results in /WebKit/WebKitBuild/Release/layout-test-results Baseline search path: platform/mac-wk2 -> platform/wk2 -> platform/mac -> generic Using Release build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /WebKit/WebKitBuild/Release/WebKitTestRunner - --lint-test-files warnings: LayoutTests/TestExpectations:754 Path does not exist. imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/NavigatorID.html Found 1 test; running 1, skipping 0. Running 1 test Running 1 WebKitTestRunner. The test ran as expected.
Are you sure that your local build includes the patch? These test results look like they should be occurring with your patch. Are you passing the wrong --debug or --release flag?
(In reply to Myles C. Maxfield from comment #21) > Are you sure that your local build includes the patch? These test results > look like they should be occurring with your patch. > > Are you passing the wrong --debug or --release flag? I built WebKit with the patch and then tested it without passing any flags.