NEW 172909
The spec says that we're supposed to use xx-small for font size 1. 
https://bugs.webkit.org/show_bug.cgi?id=172909
Summary The spec says that we're supposed to use xx-small for font size 1.
Karim
Reported 2017-06-04 18:03:11 PDT
The spec says that we're supposed to use xx-small for font size 1. Current spec: https://www.w3.org/TR/CSS2/fonts.html#propdef-font-size Draft spec: https://drafts.csswg.org/css-fonts-3/#font-size-prop
Attachments
Patch (1.30 KB, patch)
2017-06-04 18:28 PDT, Karim 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-elcapitan (3.41 MB, application/zip)
2017-06-04 19:27 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (3.50 MB, application/zip)
2017-06-04 19:32 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-elcapitan (4.17 MB, application/zip)
2017-06-04 19:54 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (3.19 MB, application/zip)
2017-06-04 19:55 PDT, Build Bot 		no flags
Details
Patch (1.30 KB, patch)
2017-06-04 22:29 PDT, Karim 		mcatanzaro: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-elcapitan (3.39 MB, application/zip)
2017-06-04 23:28 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (3.43 MB, application/zip)
2017-06-04 23:31 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (3.19 MB, application/zip)
2017-06-04 23:55 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-elcapitan (4.17 MB, application/zip)
2017-06-04 23:59 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Karim
Comment 1 2017-06-04 18:28:50 PDT
Created attachment 311974 [details] Patch
Build Bot
Comment 2 2017-06-04 19:27:13 PDT
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3873494 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Build Bot
Comment 3 2017-06-04 19:27:15 PDT
Created attachment 311976 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 4 2017-06-04 19:32:26 PDT
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3873499 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Build Bot
Comment 5 2017-06-04 19:32:28 PDT
Created attachment 311978 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-06-04 19:54:26 PDT
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3873509 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Build Bot
Comment 7 2017-06-04 19:54:27 PDT
Created attachment 311979 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 8 2017-06-04 19:55:34 PDT
Comment on attachment 311974 [details] Patch Attachment 311974 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3873526 New failing tests: tables/mozilla/bugs/bug57828-2.html tables/mozilla/bugs/bug113424.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug647.html fast/text/basic/011.html fast/forms/form-element-geometry.html tables/mozilla/other/slashlogo.html tables/mozilla/bugs/bug16012.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/core/bloomberg.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html editing/execCommand/query-font-size.html tables/mozilla/bugs/bug4093.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug22513.html tables/mozilla/other/ms.html
Build Bot
Comment 9 2017-06-04 19:55:35 PDT
Created attachment 311980 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Karim
Comment 10 2017-06-04 22:29:13 PDT
Created attachment 311982 [details] Patch
Build Bot
Comment 11 2017-06-04 23:28:29 PDT
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3874316 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Build Bot
Comment 12 2017-06-04 23:28:30 PDT
Created attachment 311985 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 13 2017-06-04 23:31:38 PDT
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3874374 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Build Bot
Comment 14 2017-06-04 23:31:39 PDT
Created attachment 311986 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 15 2017-06-04 23:55:54 PDT
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3874364 New failing tests: tables/mozilla/bugs/bug57828-2.html tables/mozilla/bugs/bug113424.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug647.html fast/text/basic/011.html fast/forms/form-element-geometry.html tables/mozilla/other/slashlogo.html tables/mozilla/bugs/bug16012.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/core/bloomberg.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html editing/execCommand/query-font-size.html tables/mozilla/bugs/bug4093.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug22513.html tables/mozilla/other/ms.html
Build Bot
Comment 16 2017-06-04 23:55:55 PDT
Created attachment 311988 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Build Bot
Comment 17 2017-06-04 23:59:48 PDT
Comment on attachment 311982 [details] Patch Attachment 311982 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3874340 New failing tests: tables/mozilla/bugs/bug647.html tables/mozilla_expected_failures/bugs/bug11331.html tables/mozilla/bugs/bug16012.html tables/mozilla/bugs/bug22513.html editing/selection/3690719.html tables/mozilla/bugs/bug113424.html tables/mozilla/other/slashlogo.html tables/mozilla/core/bloomberg.html fast/dom/HTMLFontElement/size-attribute.html tables/mozilla/bugs/bug1188.html tables/mozilla/bugs/bug57828-2.html editing/style/push-down-font-styles-win.html editing/selection/3690703-2.html tables/mozilla/other/ms.html fast/text/basic/001.html tables/mozilla/bugs/bug16252.html tables/mozilla/bugs/bug4093.html editing/style/push-down-font-styles-mac.html editing/selection/3690703.html fast/forms/form-element-geometry.html editing/execCommand/query-font-size.html fast/text/basic/011.html
Build Bot
Comment 18 2017-06-04 23:59:50 PDT
Created attachment 311989 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Michael Catanzaro
Comment 19 2017-07-02 09:13:46 PDT
Comment on attachment 311982 [details] Patch Hi, thanks for this patch. It looks like you'll need to rebaseline the failing tests if you want to fix this bug.
Karim
Comment 20 2017-08-08 08:32:02 PDT
(In reply to Michael Catanzaro from comment #19) > Comment on attachment 311982 [details] > Patch > > Hi, thanks for this patch. It looks like you'll need to rebaseline the > failing tests if you want to fix this bug. When i run the tests that did fail for eg: Tools/Scripts/run-webkit-tests editing/execCommand/query-font-size.html I get the following result witch seem to be succeed, but when i upload the patch the tests fail Using port 'mac-sierra-wk2' Test configuration: <sierra, x86_64, release> Placing test results in /WebKit/WebKitBuild/Release/layout-test-results Baseline search path: platform/mac-wk2 -> platform/wk2 -> platform/mac -> generic Using Release build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /WebKit/WebKitBuild/Release/WebKitTestRunner - --lint-test-files warnings: LayoutTests/TestExpectations:754 Path does not exist. imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/NavigatorID.html Found 1 test; running 1, skipping 0. Running 1 test Running 1 WebKitTestRunner. The test ran as expected.
Myles C. Maxfield
Comment 21 2017-08-09 18:04:21 PDT
Are you sure that your local build includes the patch? These test results look like they should be occurring with your patch. Are you passing the wrong --debug or --release flag?
Karim
Comment 22 2017-08-09 22:55:02 PDT
(In reply to Myles C. Maxfield from comment #21) > Are you sure that your local build includes the patch? These test results > look like they should be occurring with your patch. > > Are you passing the wrong --debug or --release flag? I built WebKit with the patch and then tested it without passing any flags.
Note You need to log in before you can comment on or make changes to this bug.