Bug 113424 - Prepare extend-selection-enclosing-block test to support different editing behavior
Summary: Prepare extend-selection-enclosing-block test to support different editing be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 110487
  Show dependency tree / graph
 
Reported: 2013-03-27 10:48 PDT by Claudio Saavedra
Modified: 2013-03-28 12:57 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.44 KB, patch)
2013-03-27 10:49 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Patch (7.51 KB, patch)
2013-03-27 10:58 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Patch for landing (7.45 KB, patch)
2013-03-28 12:22 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2013-03-27 10:48:06 PDT 
Prepare extend-selection-enclosing-block test to support different editing behavior
Comment 1 Claudio Saavedra 2013-03-27 10:49:02 PDT 
Created attachment 195352 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-27 10:51:44 PDT 
Attachment 195352 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/editing/selection/extend-selection-enclosing-block-expected.txt', u'LayoutTests/editing/selection/extend-selection-enclosing-block-mac-expected.txt', u'LayoutTests/editing/selection/extend-selection-enclosing-block-mac.html', u'LayoutTests/editing/selection/extend-selection-enclosing-block.html', u'LayoutTests/editing/selection/resources/extend-selection.js']" exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Claudio Saavedra 2013-03-27 10:58:11 PDT 
Created attachment 195357 [details]
Patch
Comment 4 Ryosuke Niwa 2013-03-28 11:27:28 PDT 
Comment on attachment 195357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195357&action=review

> LayoutTests/editing/selection/resources/extend-selection.js:111
> +    return extendAndLogSelection({'mac': extendSelectionWithinBlock }[platform],

Nit: space before }.

> LayoutTests/editing/selection/resources/extend-selection.js:113
>  }

Wrong indentation. direction should be exactly 4 specs to the right of return. It seems like we can fit all of this in one line anyway.
Comment 5 Claudio Saavedra 2013-03-28 12:22:54 PDT 
Created attachment 195618 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-03-28 12:57:40 PDT 
Comment on attachment 195618 [details]
Patch for landing

Clearing flags on attachment: 195618

Committed r147146: <http://trac.webkit.org/changeset/147146>
Comment 7 WebKit Review Bot 2013-03-28 12:57:43 PDT 
All reviewed patches have been landed.  Closing bug.