Bug 113424 – Prepare extend-selection-enclosing-block test to support different editing behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Claudio Saavedra]

Prepare extend-selection-enclosing-block test to support different editing behavior

[Claudio Saavedra]

Created attachment 195352 [details]
Patch

[WebKit Review Bot]

Attachment 195352 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/editing/selection/extend-selection-enclosing-block-expected.txt', u'LayoutTests/editing/selection/extend-selection-enclosing-block-mac-expected.txt', u'LayoutTests/editing/selection/extend-selection-enclosing-block-mac.html', u'LayoutTests/editing/selection/extend-selection-enclosing-block.html', u'LayoutTests/editing/selection/resources/extend-selection.js']" exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Claudio Saavedra]

Created attachment 195357 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 195357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195357&action=review

> LayoutTests/editing/selection/resources/extend-selection.js:111
> +    return extendAndLogSelection({'mac': extendSelectionWithinBlock }[platform],

Nit: space before }.

> LayoutTests/editing/selection/resources/extend-selection.js:113
>  }

Wrong indentation. direction should be exactly 4 specs to the right of return. It seems like we can fit all of this in one line anyway.

[Claudio Saavedra]

Created attachment 195618 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 195618 [details]
Patch for landing

Clearing flags on attachment: 195618

Committed r147146: <http://trac.webkit.org/changeset/147146>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.