Bug 169093 – [WebCrypto] Implement ECDH GenerateKey operation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Implement ECDH GenerateKey operation according to the spec: https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations.

[Jiewen Tan]

<rdar://problem/23789585>

[Jiewen Tan]

Created attachment 303367 [details]
Patch

[Jiewen Tan]

Created attachment 303373 [details]
Patch

[WebKit Commit Bot]

Attachment 303373 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jiewen Tan]

Created attachment 303379 [details]
Patch

[WebKit Commit Bot]

Attachment 303379 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jiewen Tan]

Created attachment 303381 [details]
Patch

[WebKit Commit Bot]

Attachment 303381 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 303381 [details]
Patch

Attachment 303381 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3235738

New failing tests:
fast/events/media-focus-in-standalone-media-document.html

[Build Bot]

Created attachment 303385 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Brent Fulgham]

Comment on attachment 303381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303381&action=review

Looks good. r=me with some comment and other clean-up.

> Source/WebCore/ChangeLog:11
> +        Note: Sad that we are not able to support P-521 at this moment since

"since the inability of the underlying crypto library." should be "due to lack of necessary support in the underlying crypto library."

Also: Is there a Radar for this we can reference in the code so we remember to turn the P-521 support on once it is available?

> Source/WebCore/ChangeLog:25
> +        We didn't add fake implementation to GTK this time as a platform key is needed.

I don't think this comment relates to "project.pbxproj", since that is a Mac/iOS-specific file.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1212
> +            // A dummy implementation for now.

Is there a Bugzila tracking the work to implement this change? We should list it here.

[Jiewen Tan]

Comment on attachment 303381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303381&action=review

Thanks Brent for r+ my patch.

>> Source/WebCore/ChangeLog:11
>> +        Note: Sad that we are not able to support P-521 at this moment since
> 
> "since the inability of the underlying crypto library." should be "due to lack of necessary support in the underlying crypto library."
> 
> Also: Is there a Radar for this we can reference in the code so we remember to turn the P-521 support on once it is available?

Fixed.
Here is the bug: https://bugs.webkit.org/show_bug.cgi?id=169231

>> Source/WebCore/ChangeLog:25
>> +        We didn't add fake implementation to GTK this time as a platform key is needed.
> 
> I don't think this comment relates to "project.pbxproj", since that is a Mac/iOS-specific file.

Removed.

>> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1212
>> +            // A dummy implementation for now.
> 
> Is there a Bugzila tracking the work to implement this change? We should list it here.

Here is the bug: https://bugs.webkit.org/show_bug.cgi?id=169232

[Jiewen Tan]

Created attachment 303580 [details]
Patch for landing

[WebKit Commit Bot]

Attachment 303580 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:67:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:68:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jiewen Tan]

Created attachment 303582 [details]
Patch for landing

[WebKit Commit Bot]

Attachment 303582 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:67:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:68:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/crypto/CryptoKey.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 4 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 303582 [details]
Patch for landing

Clearing flags on attachment: 303582

Committed r213489: <http://trac.webkit.org/changeset/213489>