Bug 169232 - [WebCrypto] Make sure all CryptoKey classes are structured clonable
Summary: [WebCrypto] Make sure all CryptoKey classes are structured clonable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 166746
  Show dependency tree / graph
 
Reported: 2017-03-06 15:59 PST by Jiewen Tan
Modified: 2017-03-17 14:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (31.03 KB, patch)
2017-03-16 20:57 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2017-03-06 15:59:37 PST 
Make CryptoKeyEC structured clonable.
Comment 1 Jiewen Tan 2017-03-06 16:00:52 PST 
<rdar://problem/23789585>
Comment 2 Jiewen Tan 2017-03-09 00:32:13 PST 
(In reply to comment #1)
> <rdar://problem/23789585>

This radar is faked.
Comment 3 Jiewen Tan 2017-03-09 00:33:06 PST 
We should make sure all CryptoKey classes are structured clonable.
Comment 4 Jiewen Tan 2017-03-09 00:35:36 PST 
This includes CryptoKeyAES, CryptoKeyHMAC, CryptoKeyEE, CryptoKeyRSA and CryptoKeyRaw.
Comment 5 Jiewen Tan 2017-03-09 00:37:06 PST 
For all CryptoKey, we should make sure they have move constructors.
Comment 6 Jiewen Tan 2017-03-16 20:47:00 PDT 
<rdar://problem/31106660>
Comment 7 Jiewen Tan 2017-03-16 20:57:41 PDT 
Created attachment 304747 [details]
Patch
Comment 8 WebKit Commit Bot 2017-03-16 20:59:50 PDT 
Attachment 304747 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:196:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:197:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Brent Fulgham 2017-03-17 13:18:29 PDT 
Comment on attachment 304747 [details]
Patch

r=me.
Comment 10 Jiewen Tan 2017-03-17 13:48:59 PDT 
Comment on attachment 304747 [details]
Patch

Thanks Brent for r+ my patch.
Comment 11 WebKit Commit Bot 2017-03-17 14:18:46 PDT 
Comment on attachment 304747 [details]
Patch

Clearing flags on attachment: 304747

Committed r214122: <http://trac.webkit.org/changeset/214122>
Comment 12 WebKit Commit Bot 2017-03-17 14:18:50 PDT 
All reviewed patches have been landed.  Closing bug.