Support Elliptic Curve P-521.
<rdar://problem/30881703>
Consider writing a test to derive hmac key with length unset. Currently the smallest hmac default length key is 512. No way to derive such large keys from current ECDH.
Jiewen, any plans for this? I implemented some support for this in the WIP patch in bug #175199, but for the tests I focused on the W3C ones, and the libgcrypt implementation is capable of passing a big majority of them. Do you have some work already lined up? Should we first come up with P-521 versions of the current WebKit layout tests covering EC?
(In reply to Zan Dobersek from comment #3) > Jiewen, any plans for this? > > I implemented some support for this in the WIP patch in bug #175199, but for > the tests I focused on the W3C ones, and the libgcrypt implementation is > capable of passing a big majority of them. > > Do you have some work already lined up? Should we first come up with P-521 > versions of the current WebKit layout tests covering EC? No, I don't have any plans for supporting P-521 yet since it needs the underlying CommonCrypto's support. Given the security strength of P-521, I think it is not needed in a near future. Feel free to implement a GCrypt support with sufficient WebKit tests.
Created attachment 319363 [details] WIP patch
Attachment 319363 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319587 [details] Patch
Attachment 319587 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 319587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319587&action=review Looks good to me. Thanks for adding the support for P-521. > Source/WebCore/crypto/mac/CryptoKeyECMac.cpp:226 > + ASSERT_NOT_REACHED(); Probably ASSERT_NOT_REACHED() is better?
Comment on attachment 319587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319587&action=review >> Source/WebCore/crypto/mac/CryptoKeyECMac.cpp:226 >> + ASSERT_NOT_REACHED(); > > Probably ASSERT_NOT_REACHED() is better? Sorry, please ignore this comment.
Created attachment 321416 [details] Patch for landing
(In reply to Zan Dobersek from comment #11) > Created attachment 321416 [details] > Patch for landing Thanks for the review. This is just the rebased patch that I'll land in a moment.
Attachment 321416 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/keys/CryptoKeyEC.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 321416 [details] Patch for landing Clearing flags on attachment: 321416 Committed r222316: <http://trac.webkit.org/changeset/222316>
All reviewed patches have been landed. Closing bug.