Update flexbox to Blink's tip of tree
Created attachment 302269 [details] Patch
Created attachment 302270 [details] Patch
Attachment 302270 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:1265: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 330 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 302269 [details] Patch - use modern for loops - WTFMove vectors if possible - use default member initializers if possible - use 'use' instead of typdef - use SetForScope instead of manually saving and restoring values (oldInLayout) - use is<RendererType>(renderer) instead of renderer.isRendererType() - remove extra lines/spaces/comments like // MERGEPOINT - not sure about the WebKit style on this, but you can use operator* instead of std::optional::value() - we tend to not use const auto& -unless there's a good reason. - use enum class instead of enum - add SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderType, isRenderType()) for new isRendererType() I can't possibly review the logic in here (I will try though in a second pass)
Created attachment 302294 [details] Patch
Comment on attachment 302294 [details] Patch Attachment 302294 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3167705 New failing tests: css3/flexbox/flexbox-overflow-auto.html fullscreen/video-cursor-auto-hide.html css3/flexbox/flex-align-vertical-writing-mode.html css3/flexbox/flex-order.html fast/css-grid-layout/relayout-justify-items-changed.html css3/flexbox/flex-flow-auto-margins-no-available-space-assert.html css3/flexbox/columns-auto-size.html fast/repaint/justify-items-change.html css3/flexbox/flex-align.html fast/css-grid-layout/relayout-align-items-changed.html fast/table/colspanMinWidth-vertical.html
Created attachment 302297 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 302294 [details] Patch Attachment 302294 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3167815 New failing tests: css3/flexbox/flexbox-overflow-auto.html fullscreen/video-cursor-auto-hide.html css3/flexbox/flex-align-vertical-writing-mode.html css3/flexbox/flex-order.html fast/css-grid-layout/relayout-justify-items-changed.html fast/repaint/justify-items-change.html css3/flexbox/columns-auto-size.html css3/flexbox/flex-flow-auto-margins-no-available-space-assert.html css3/flexbox/flex-align.html fast/css-grid-layout/relayout-align-items-changed.html fast/table/colspanMinWidth-vertical.html
Created attachment 302300 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302294 [details] Patch Attachment 302294 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3167800 New failing tests: css3/flexbox/flexbox-overflow-auto.html fullscreen/video-cursor-auto-hide.html css3/flexbox/flex-align-vertical-writing-mode.html css3/flexbox/flex-order.html fast/css-grid-layout/relayout-justify-items-changed.html fast/repaint/justify-items-change.html css3/flexbox/columns-auto-size.html css3/flexbox/flex-flow-auto-margins-no-available-space-assert.html css3/flexbox/flex-align.html fast/css-grid-layout/relayout-align-items-changed.html fast/table/colspanMinWidth-vertical.html
Created attachment 302302 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302294 [details] Patch Attachment 302294 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3167807 New failing tests: css3/flexbox/flexbox-overflow-auto.html css3/flexbox/flex-align-vertical-writing-mode.html css3/flexbox/flex-order.html fast/css-grid-layout/relayout-justify-items-changed.html css3/flexbox/flexbox-height-with-overflow-auto.html media/video-controls-rendering.html media/controls-without-preload.html css3/flexbox/flex-flow-auto-margins-no-available-space-assert.html css3/flexbox/columns-auto-size.html media/controls-strict.html css3/flexbox/flex-align.html fast/css-grid-layout/relayout-align-items-changed.html fast/table/colspanMinWidth-vertical.html css3/flexbox/overflow-auto-resizes-correctly.html css3/flexbox/flex-one-sets-flex-basis-to-zero-px.html
Created attachment 302303 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
rdar://problem/30351511
Created attachment 302592 [details] Patch
Comment on attachment 302592 [details] Patch Attachment 302592 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3181757 New failing tests: fast/table/003.html css3/flexbox/overflow-auto-resizes-correctly.html fast/replaced/table-percent-height.html css3/flexbox/flexbox-height-with-overflow-auto.html css3/flexbox/flex-flow-auto-margins-no-available-space-assert.html fast/table/colspanMinWidth-vertical.html css3/flexbox/flex-one-sets-flex-basis-to-zero-px.html
Created attachment 302608 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 302592 [details] Patch Attachment 302592 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3181834 New failing tests: css2.1/20110323/height-percentage-005.htm fullscreen/video-cursor-auto-hide.html fast/table/colspanMinWidth-vertical.html
Created attachment 302609 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 302592 [details] Patch Attachment 302592 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3181907 New failing tests: fullscreen/video-cursor-auto-hide.html fast/table/colspanMinWidth-vertical.html
Created attachment 302615 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302592 [details] Patch Attachment 302592 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3184376 New failing tests: css2.1/20110323/height-percentage-005.htm fullscreen/video-cursor-auto-hide.html fast/table/colspanMinWidth-vertical.html
Created attachment 302664 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Only two actual failures here, the css2.1 test case and the fullscreen. Rest just need to be skipped or rebaselined. I have a fix for the fullscreen issue and am rebuilding release now in order to see what's up with the css2.1 test.
Created attachment 302671 [details] Patch
Comment on attachment 302671 [details] Patch Attachment 302671 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3187207 New failing tests: fast/table/003.html fast/table/colspanMinWidth-vertical.html
Created attachment 302684 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 302671 [details] Patch Attachment 302671 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3187277 New failing tests: fast/table/colspanMinWidth-vertical.html
Created attachment 302686 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 302671 [details] Patch Attachment 302671 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3187400 New failing tests: fast/table/colspanMinWidth-vertical.html
Created attachment 302690 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302671 [details] Patch Attachment 302671 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3188118 New failing tests: fast/table/colspanMinWidth-vertical.html
Created attachment 302720 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
This is ready to go. The remaining failures just need rebaselines once landed.
Comment on attachment 302671 [details] Patch Please update test results before landing. After all the infrastructure troubles, the tree is not in a state that would make it easy to iterate live.
Created attachment 302846 [details] Patch
Comment on attachment 302846 [details] Patch As we discussed, follow-up patches should address the review comments ^^
Landed in r213149.
*** Bug 150445 has been marked as a duplicate of this bug. ***
Looks like it regressed one layout test on GTK port, bug #169010.
Some comments about this patch and the bits related to Grid Layout. Please, next time ping any of us (svillar, jfernadez or me) to take a look to the Grid Layout stuff. I don't know why we didn't get notified as in theory we're in the "CSSGridLayout" watchlist. * I think that the new hasDefiniteLogicalHeight() implementation could be split in a separated patch. That change how percentage heights are resolved for any element (not only flexbox or grid), so it'd be nice to have it isolated on a different patch; as it might introduce some regressions and it'd be easier to identify or rollout if needed. The related patches on Blink are: * https://chromium.googlesource.com/chromium/src/+/9a12b00b915eccd82d4444ecba101f27e2761769 * https://chromium.googlesource.com/chromium/src/+/c4dc5e50ffa3ca4bef23a105ae8dc8304926b312 It'd be nice to also import the Grid Layout tests from them. * Also the changes related to percentage gaps support (RenderGrid::gridGapForDirection()) were imported as part of this. I don't see a clear reason to import them as part of this patch, and I believe this could be done on a separated patch. Note that right now we have some code that is never executed, as the parser was not modified and percentage gaps are not allowed yet (at parsing level, layout code seems ready for them). We should enable percentage gaps on the parser and import the tests from Blink too: * https://chromium.googlesource.com/chromium/src/+/78579c71b9013a88936d31b6ac4ce4b18b0ac339
*** Bug 116484 has been marked as a duplicate of this bug. ***
*** Bug 118638 has been marked as a duplicate of this bug. ***