RESOLVED DUPLICATE of bug 168657 Bug 116484
Simplify RenderFlexibleBox::computeMainAxisExtentForChild 
https://bugs.webkit.org/show_bug.cgi?id=116484
Summary Simplify RenderFlexibleBox::computeMainAxisExtentForChild
Ryosuke Niwa
Reported 2013-05-20 18:22:26 PDT
We should consider merging https://chromium.googlesource.com/chromium/blink/+/b2181608f7b4697190b880d8a2d7b302a96d031e Simplify RenderFlexibleBox::computeMainAxisExtentForChild We only need to check size.isIntrinsic(), not all of height/min-height/max-height. We can also use layoutIfNeeded(). No new tests - no behavior change.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-08-22 17:00:01 PDT
I don't understand the refactoring done - https://github.com/WebKit/WebKit/blob/62e012dfc64a13172b55d9115d77119ec8dbe794/Source/WebCore/rendering/RenderFlexibleBox.cpp#L653 Appreciate if someone can have a look and see if anything else is needed here or not? Thanks!
Ryan Reno
Comment 2 2022-08-22 20:27:26 PDT
This was resolved in a mass Blink flexbox import. https://bugs.webkit.org/show_bug.cgi?id=168657 *** This bug has been marked as a duplicate of bug 168657 ***
Note You need to log in before you can comment on or make changes to this bug.