Bug 170764 – [css-grid] Add support for percentage gaps

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Manuel Rego Casasnovas]

This has been already implemented in Blink.
Part of the code related to this was already imported into WebKit
in bug #168657 but never used yet as the parsing was disabled.
We should enable the use of percentages in parsing
and then import the tests from Blink related to this.

[Manuel Rego Casasnovas]

Created attachment 306891 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 306897 [details]
Mini change on ChangeLog

[Build Bot]

Comment on attachment 306897 [details]
Mini change on ChangeLog

Attachment 306897 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3522867

New failing tests:
webrtc/negotiatedneeded-event-addStream.html

[Build Bot]

Created attachment 306901 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306897 [details]
Mini change on ChangeLog

Attachment 306897 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3522979

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html

[Build Bot]

Created attachment 306906 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sergio Villar Senin]

Comment on attachment 306897 [details]
Mini change on ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=306897&action=review

> LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html:15
> +.rows50-50 { grid-template-rows: 50px 50px; }

We haven't used this kind of notation %d-%d for class names in the past. We normally do things like two100Column or things like that.

> LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:33
> +.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; }

Seems unrelated?

> LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:44
> +.gridInvalidImplicitGridGap { grid-gap: -webkit-fit-content; }

Ditto.

[Manuel Rego Casasnovas]

Created attachment 307385 [details]
Patch for landing

[Manuel Rego Casasnovas]

Comment on attachment 306897 [details]
Mini change on ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=306897&action=review

Thanks for the review.

>> LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html:15
>> +.rows50-50 { grid-template-rows: 50px 50px; }
> 
> We haven't used this kind of notation %d-%d for class names in the past. We normally do things like two100Column or things like that.

Ok, changed that.

>> LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:33
>> +.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; }
> 
> Seems unrelated?

Indeed, a copy&paste issue. :-)

[WebKit Commit Bot]

Comment on attachment 307385 [details]
Patch for landing

Clearing flags on attachment: 307385

Committed r215463: <http://trac.webkit.org/changeset/215463>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.