WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 168657
Bug 118638
Flexbox: Rename various variables and arguments to match the naming from the spec
https://bugs.webkit.org/show_bug.cgi?id=118638
Summary
Flexbox: Rename various variables and arguments to match the naming from the ...
Ryosuke Niwa
Reported
2013-07-12 23:50:12 PDT
Consider merging
https://chromium.googlesource.com/chromium/blink/+/4a723f1500205a05096946476bdc84b56a24f90f
This should make it easier to understand the code. I have also simplified some calculations and gave some expressions their own variables.
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-10-14 12:42:25 PDT
@Sam - is this applicable anymore?
Sammy Gill
Comment 2
2023-10-17 16:19:04 PDT
Looking at both the patch in question and the current code I don't think so. Looks like we merged in those changes and some others when we rebased the flex code off of Blink's ToT a while ago:
https://bugs.webkit.org/show_bug.cgi?id=168657
Sammy Gill
Comment 3
2024-01-02 11:02:45 PST
Going to go ahead and resolve this since it was already taken care of by the rebase we did a while back *** This bug has been marked as a duplicate of
bug 168657
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug